Giter Club home page Giter Club logo

Comments (2)

light-and-ray avatar light-and-ray commented on June 15, 2024

Thanks for your message

Instead of being a full fledged tab

I like to use a dedicated tab, I think regular img2img tab is too complicated for my extension. The benefit of using all img2img scripts was questionable because it seems no one fit for inpainting except controlnet and tiled vae. And placing replacer tab next to other img2img tabs would break the idea of maximum fast inpaint. Later I decided to add custom mask and inpaint diff into advanced options just to have they there and take advantages of hires fix and cn inpainting

I just updated it like a week ago to add a few parameters to it, so in a sense, it is not a stable way to do this.

Yes, I understand it. It's an inevitable problem with using of any external extension. I think the best way I will fix it if you change something, like I'm doing for controlnet. Do not care about it. At least your development won't be endless 😃 idk how much new features are possible to add in your original idea

with a variable amount of parameters (*args) would be better, for example

It's impossible because if takes parametres from gradio's input

You could also highjack it, and run your extension when the compute_mask function returns?

This can solve a problem when an author changes returned variables, but for other cases it won't fix it as I see

from sd-webui-replacer.

John-WL avatar John-WL commented on June 15, 2024

I see, if you don't mind having to maintain the arguments, there's no problem then. I'll close the issue 👍
For new features in Inpaint difference, you never know! I keep thinking of new things to add to it :p
For example, I was thinking of adding an option to only return the inpainted masked region, and leave the rest of the image with full alpha when returning the image (to use as a layer in clip studio paint).

from sd-webui-replacer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.