Giter Club home page Giter Club logo

Comments (4)

mthadley avatar mthadley commented on August 31, 2024 1

If it was my choice, I'd probably go for number 2 (I usually prefer the terser styles anyways).

from liferay-frontend-source-formatter.

natecavanaugh avatar natecavanaugh commented on August 31, 2024

Heya Bryce,
Yeah, I saw this one recently and I wasn't 100% sure what to do about it either.

I could only think of 3 possible solutions:

  1. Assigning the configObj to a variable outside of the JSX context, and only pass that

  2. Change the formatting from:

    configObj={
        {
            ...
        }
    }

    to

    configObj={{
        ...
    }}
  3. Copy the rule implementation, and tweak it to allow indenting of objects.

Do you guys have any thoughts on this one?

from liferay-frontend-source-formatter.

bryceosterhaus avatar bryceosterhaus commented on August 31, 2024

Yeah I would also prefer number 2, would hope for same formatting for arrays as well.

configObj={[
    ...
]}

from liferay-frontend-source-formatter.

natecavanaugh avatar natecavanaugh commented on August 31, 2024

Hey guys,
I'm good with going with that change :) I'll also look into some other ways of enforcing that particular formatting style.

Thanks for the input guys.

from liferay-frontend-source-formatter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.