Comments (4)
If it was my choice, I'd probably go for number 2 (I usually prefer the terser styles anyways).
from liferay-frontend-source-formatter.
Heya Bryce,
Yeah, I saw this one recently and I wasn't 100% sure what to do about it either.
I could only think of 3 possible solutions:
-
Assigning the
configObj
to a variable outside of the JSX context, and only pass that -
Change the formatting from:
configObj={ { ... } }
to
configObj={{ ... }}
-
Copy the rule implementation, and tweak it to allow indenting of objects.
Do you guys have any thoughts on this one?
from liferay-frontend-source-formatter.
Yeah I would also prefer number 2, would hope for same formatting for arrays as well.
configObj={[
...
]}
from liferay-frontend-source-formatter.
Hey guys,
I'm good with going with that change :) I'll also look into some other ways of enforcing that particular formatting style.
Thanks for the input guys.
from liferay-frontend-source-formatter.
Related Issues (20)
- The source code did not change at all. Why? HOT 4
- New lines are being added between comments and logic HOT 4
- Unclear warning: "function declaration was used before it was defined" HOT 2
- Integrate with Prettier HOT 13
- SF fails with "try" string and break methods in .js files HOT 2
- Less verbose output HOT 2
- Convert to monorepo? HOT 3
- Add VSCode extension HOT 2
- Force new line on HTML attributes when there are more than two properties (Soy, JSX) HOT 4
- Enforce/disallow HTML void tags' slash HOT 2
- Explanation for "Block level containers need either a class or id" HOT 4
- Wrap JSDoc comments to 80 columns HOT 3
- Running the source formatter breaks some functions calls HOT 2
- Force/disallow new line when chaining HOT 1
- Forcing on code block braces breaks indentation HOT 3
- Force concrete formatting for long conditionals HOT 5
- Force function newline for each parameters HOT 2
- Force newline between different "code blocks" HOT 2
- Provide linting for arrow function parens HOT 1
- Force more consistent JSDoc typing HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from liferay-frontend-source-formatter.