Rate limit exceeded about node-callofduty HOT 9 CLOSED

Will implement axios-rate-limit package later on and will add some defaults.

Will also allow these to be changed but up to the person using the API to handle the rate limit exceptions.

I will update this issue when completed.

Thanks! 😄

from node-callofduty.

https://github.com/aishek/axios-rate-limit

This could be used to local rate limit if the developer adds it in, should be very simple to implement

from node-callofduty.

It's look good yes

Very useful to implement this!

from node-callofduty.

Decided not to add the rate limit package as mentioned above but have added a login method which should reduce the rate-limiting unless you are hammering the API.

from node-callofduty.

Decided not to add the rate limit package as mentioned above but have added a login method which should reduce the rate-limiting unless you are hammering the API.

I am still getting rate limited pretty heavily, I would recommend exposing the apiAxios in the module so we can add our own rate limits without modifying this package

It should be as simple as adding module.axios = apiAxios; into index,js

I would also like to request that if a request fails you don't hardcode "Rate Limited", instead let the catch block report the error

from node-callofduty.

Hi, @Flupster,

The API will only return rate-limited if you are in fact limited.

I will expose Axios in an update later today.

from node-callofduty.

Update:

I have added axios-rate-limit and exposed apiaxios too in this commit

Hope this helps.

from node-callofduty.

Update:

I have added axios-rate-limit and exposed apiaxios too in this commit

Hope this helps.

Very nice, do you have any idea of the rate limit by cod?

Their headers don't supply any information, I was calling MWcombatwz and there was no rate limit for the user logged in, but if you were to check 3 or 4 different gamertags sporadically over a minute or two a rate limit gets applied, so it leads me to believe there is a maximum requests per hour for the API, would be nice to have exact figure so axios rate limit can be tuned perfectly to not get rate limited

from node-callofduty.

I haven't noticed any pattern with rate limits, I usually stick to a call every 4 seconds and it works fine.
I would have to investigate further.

from node-callofduty.