Comments (31)
SoapGentoo
commented on June 25, 2024
2
Thanks everyone, we're done here, just cut 0.2.0 and uploaded it.
from libsamplerate.
NancyLi1013
commented on June 25, 2024
1
@evpobr and @SoapGentoo
I'm a maintainer for vcpkg. We're waiting for the new release of libsamplerate that supports cmake targets. Could you please help confirm when the next release will be ready?
Thanks in advance.
from libsamplerate.
evpobr
commented on June 25, 2024
1
I guess no. Just add release date to NEWS and release entry to history.md.
from libsamplerate.
Flamefire
commented on June 25, 2024
Please fix #5 first as the current master contains a potential out-of-bounds read: #5 (comment)
from libsamplerate.
dvzrv
commented on June 25, 2024
@erikd Hi! I package libsamplerate for Arch Linux.
It would be really awesome to have a new release of this great and integral piece of software. Are there major blockers to make this happen?
In the case of a release, would it be possible for you to add a PGP signature for the tarball?
Currently we're downloading tarballs and can't verify their authenticity and only do checksum checking.
from libsamplerate.
Flamefire
commented on June 25, 2024
Github automatically creates tarballs for tags so signing could be hard. But There is commit signing integrated with git. If a commit is signed and the git checksum matches then this should be enough
from libsamplerate.
dvzrv
commented on June 25, 2024
@Flamefire yes, signed commits and tags would also work (for me)!
from libsamplerate.
SoapGentoo
commented on June 25, 2024
- automatic tags are mostly useless for Autotools projects, as you need to bootstrap the tarball anyways. Which means you'll have to upload the bootstrapped tarball anyhow, and while at it, you might as well upload a detached
.ascsignature of the bootstrapped tarball. - because of the bootstrapped tarball, there exists an (authentication) gap between the signed commit and the actual bootstrapped tarball.
In Adplug, we have uploaded signed tarballs: https://github.com/adplug/adplug/releases/tag/adplug-2.3.1
from libsamplerate.
Flamefire
commented on June 25, 2024
True. Forgot that autotools is still used. I'm using cmake and never looked back...
from libsamplerate.
evpobr
commented on June 25, 2024
@SoapGentoo, i guess it is time for new release. Assign a date to v.0.1.10 milestone if you don't mind.
I've published release-v0.1.10 branch with updated NEWS for you.
from libsamplerate.
evpobr
commented on June 25, 2024
I guess it is actually 0.20, new src_clone () function added.
from libsamplerate.
SoapGentoo
commented on June 25, 2024
yes, we definitely need a new release of libsamplerate, the current one is massively out of date.
from libsamplerate.
Be-ing
commented on June 25, 2024
Ping @evpobr. I am also running into trouble using libsamplerate with vcpkg on macOS. The build was fixed by #81 which was merged 1.5 years ago but there has been no release since then. For now I am hacking around this by using master with vcpkg. The build fails with:
[1/6] /Applications/Xcode_12.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -fPIC -g -arch x86_64 -isysroot /Applications/Xcode_12.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk -mmacosx-version-min=10.15 -MD -MT CMakeFiles/libsamplerate-0.dir/src_zoh.o -MF CMakeFiles/libsamplerate-0.dir/src_zoh.o.d -o CMakeFiles/libsamplerate-0.dir/src_zoh.o -c /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/src_zoh.c
FAILED: CMakeFiles/libsamplerate-0.dir/src_zoh.o
/Applications/Xcode_12.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -fPIC -g -arch x86_64 -isysroot /Applications/Xcode_12.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk -mmacosx-version-min=10.15 -MD -MT CMakeFiles/libsamplerate-0.dir/src_zoh.o -MF CMakeFiles/libsamplerate-0.dir/src_zoh.o.d -o CMakeFiles/libsamplerate-0.dir/src_zoh.o -c /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/src_zoh.c
In file included from /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/src_zoh.c:14:
/Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/float_cast.h:254:5: error: invalid instruction mnemonic 'fctiw'
( "fctiw %1, %1\n\t"
^
<inline asm>:1:2: note: instantiated into assembly here
fctiw %st, %st
^~~~~
In file included from /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/src_zoh.c:14:
/Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/float_cast.h:254:20: error: invalid instruction mnemonic 'stfd'
( "fctiw %1, %1\n\t"
^
<inline asm>:2:2: note: instantiated into assembly here
stfd %st, -16(%rbp)
^~~~
2 errors generated.
[2/6] /Applications/Xcode_12.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -fPIC -g -arch x86_64 -isysroot /Applications/Xcode_12.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk -mmacosx-version-min=10.15 -MD -MT CMakeFiles/libsamplerate-0.dir/src_linear.o -MF CMakeFiles/libsamplerate-0.dir/src_linear.o.d -o CMakeFiles/libsamplerate-0.dir/src_linear.o -c /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/src_linear.c
FAILED: CMakeFiles/libsamplerate-0.dir/src_linear.o
/Applications/Xcode_12.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -fPIC -g -arch x86_64 -isysroot /Applications/Xcode_12.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk -mmacosx-version-min=10.15 -MD -MT CMakeFiles/libsamplerate-0.dir/src_linear.o -MF CMakeFiles/libsamplerate-0.dir/src_linear.o.d -o CMakeFiles/libsamplerate-0.dir/src_linear.o -c /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/src_linear.c
In file included from /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/src_linear.c:14:
/Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/float_cast.h:254:5: error: invalid instruction mnemonic 'fctiw'
( "fctiw %1, %1\n\t"
^
<inline asm>:1:2: note: instantiated into assembly here
fctiw %st, %st
^~~~~
In file included from /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/src_linear.c:14:
/Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/float_cast.h:254:20: error: invalid instruction mnemonic 'stfd'
( "fctiw %1, %1\n\t"
^
<inline asm>:2:2: note: instantiated into assembly here
stfd %st, -16(%rbp)
^~~~
2 errors generated.
[3/6] /Applications/Xcode_12.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -fPIC -g -arch x86_64 -isysroot /Applications/Xcode_12.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk -mmacosx-version-min=10.15 -MD -MT CMakeFiles/libsamplerate-0.dir/samplerate.o -MF CMakeFiles/libsamplerate-0.dir/samplerate.o.d -o CMakeFiles/libsamplerate-0.dir/samplerate.o -c /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/samplerate.c
FAILED: CMakeFiles/libsamplerate-0.dir/samplerate.o
/Applications/Xcode_12.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -fPIC -g -arch x86_64 -isysroot /Applications/Xcode_12.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk -mmacosx-version-min=10.15 -MD -MT CMakeFiles/libsamplerate-0.dir/samplerate.o -MF CMakeFiles/libsamplerate-0.dir/samplerate.o.d -o CMakeFiles/libsamplerate-0.dir/samplerate.o -c /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/samplerate.c
In file included from /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/samplerate.c:16:
/Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/float_cast.h:254:5: error: invalid instruction mnemonic 'fctiw'
( "fctiw %1, %1\n\t"
^
<inline asm>:1:2: note: instantiated into assembly here
fctiw %st, %st
^~~~~
In file included from /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/samplerate.c:16:
/Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/float_cast.h:254:20: error: invalid instruction mnemonic 'stfd'
( "fctiw %1, %1\n\t"
^
<inline asm>:2:2: note: instantiated into assembly here
stfd %st, -16(%rbp)
^~~~
2 errors generated.
[4/6] /Applications/Xcode_12.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -fPIC -g -arch x86_64 -isysroot /Applications/Xcode_12.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk -mmacosx-version-min=10.15 -MD -MT CMakeFiles/libsamplerate-0.dir/src_sinc.o -MF CMakeFiles/libsamplerate-0.dir/src_sinc.o.d -o CMakeFiles/libsamplerate-0.dir/src_sinc.o -c /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/src_sinc.c
FAILED: CMakeFiles/libsamplerate-0.dir/src_sinc.o
/Applications/Xcode_12.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -fPIC -g -arch x86_64 -isysroot /Applications/Xcode_12.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.0.sdk -mmacosx-version-min=10.15 -MD -MT CMakeFiles/libsamplerate-0.dir/src_sinc.o -MF CMakeFiles/libsamplerate-0.dir/src_sinc.o.d -o CMakeFiles/libsamplerate-0.dir/src_sinc.o -c /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/src_sinc.c
In file included from /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/src_sinc.c:14:
/Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/float_cast.h:254:5: error: invalid instruction mnemonic 'fctiw'
( "fctiw %1, %1\n\t"
^
<inline asm>:1:2: note: instantiated into assembly here
fctiw %st, %st
^~~~~
In file included from /Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/src_sinc.c:14:
/Users/runner/mixxx-vcpkg/buildtrees/libsamplerate/src/9c5825142a-df761b79c5.clean/src/float_cast.h:254:20: error: invalid instruction mnemonic 'stfd'
( "fctiw %1, %1\n\t"
^
<inline asm>:2:2: note: instantiated into assembly here
stfd %st, -16(%rbp)
^~~~
2 errors generated.
ninja: build stopped: subcommand failed.
Thanks for your work here and with libsndfile. ❤️
from libsamplerate.
evpobr
commented on June 25, 2024
Hi, @Be-ing. I guess Vcpkg port is outdated.
from libsamplerate.
evpobr
commented on June 25, 2024
yes, we definitely need a new release of libsamplerate, the current one is massively out of date.
@SoapGentoo, how about a new release, is there a planned timeline? Or did I misunderstand you and you will only release libsndfile?
from libsamplerate.
evpobr
commented on June 25, 2024
Branch: https://github.com/libsndfile/libsamplerate/commits/release-v0.2.0
from libsamplerate.
SoapGentoo
commented on June 25, 2024
@evpobr anything left we have to do for this release?
from libsamplerate.
evpobr
commented on June 25, 2024
Wait a little.
from libsamplerate.
evpobr
commented on June 25, 2024
@SoapGentoo , i guess it is ready. You need to update NEWS and add entry to history.md.
from libsamplerate.
Be-ing
commented on June 25, 2024
ping @SoapGentoo could you take care of updating NEWS and history.md and making the release?
from libsamplerate.
SoapGentoo
commented on June 25, 2024
@what else do I need to put in NEWS (maybe I'm missing something here)?
from libsamplerate.
SoapGentoo
commented on June 25, 2024
@evpobr I found another bug in the Automake testing harness. Here's my suggestion: let's (fast-forward) merge your stuff into master and we cut releases from master instead? Then I can add my fix to master too, and we then cut 0.2.0?
from libsamplerate.
evpobr
commented on June 25, 2024
Of course, do what you need to do with this branch.
from libsamplerate.
evpobr
commented on June 25, 2024
@SoapGentoo , Windows packages, built with CMake and Visual Studio 2019.
libsamplerate-0.2.0-win64.zip
libsamplerate-0.2.0-win32.zip
from libsamplerate.
SoapGentoo
commented on June 25, 2024
@evpobr want me to sign them as well?
from libsamplerate.
evpobr
commented on June 25, 2024
@evpobr want me to sign them as well?
Yes.
from libsamplerate.
evpobr
commented on June 25, 2024
A small note about tags. We will add the v prefix before the version tag? I mean right now we have ' v0.1.9` and '0.2.0'. I think you need to choose one style.
from libsamplerate.
SoapGentoo
commented on June 25, 2024
I'd prefer changing it all to X.Y.Z instead of vX.Y.Z, mainly because the latter is a Github thing and makes generating automatic links to the releases more annoying (and also isn't included in the actual filename of the tarballs). But if you prefer v I'll do that too.
from libsamplerate.
evpobr
commented on June 25, 2024
I think it's more a matter of taste. Let it be without a prefix.
from libsamplerate.
SoapGentoo
commented on June 25, 2024
@evpobr everything cleaned up, close if you're happy
from libsamplerate.
Be-ing
commented on June 25, 2024
vcpkg update PR: microsoft/vcpkg#15797
from libsamplerate.
Related Issues (20)
- src_process returns less samples than requested if the rate recently changed HOT 3
- CMake missing equivalent options from autoconf HOT 2
- What is a frame? HOT 3
- Calculate in advance the number of samples needed for generating a fixed size HOT 5
- Parallelize resampling (with high delay) HOT 8
- Deprecation warning CMP0091 HOT 4
- src_simple with sndfile HOT 2
- No anti-aliasing filter for linear resampling HOT 5
- Input samples needed to get n output samples? HOT 1
- src_process - zipper noise HOT 3
- Libsamplerate as fractional sample rate converter ? HOT 2
- Slow `lrint()` `lrintf()` functions in the release Windows build. HOT 12
- Fix Gihub Actions CI
- fail to build with Xcode in universal binary on OSX HOT 4
- need help with resampling the waveform in macOS HOT 1
- Don't work with more than 15 channels HOT 2
- Varispeed but preserve pitch HOT 1
- typo in libsamplerate/docs/api_full.md HOT 3
- Inconsistent input_frames_used/output_frames_gen among the numbers of channels
- Out of bound array access in src_linear.c HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libsamplerate.