GPU: Functions that may return errors should call SDL_SetError() about sdl HOT 5 OPEN

The log calls should generally be switched to SDL_SetError()

from sdl.

Error setting is reasonable on things like creation functions, where we return NULL if the creation failed, and we should do that. Error setting on hot-path commands will just be futile - those functions shouldn't return anything but void and nobody can check them for errors without turning their client code into an absolute mess.

from sdl.

We should probably have a similar policy with the SDL render API, and possibly add a debug layer there. @icculus, thoughts?

from sdl.

I think the render layer is okay as-is: it uses SDL_SetError where reasonable and doesn't need a debug layer because there isn't really much you can do with it that's a surprising silent failure, unlike using OpenGL directly.

from sdl.

We decided that anything where the underlying APIs return error codes is something we should bubble up into GPU, anything else is probably unrecoverable or we can catch obvious failures with debug mode validations.

from sdl.