Always prefer downscaling in SDL_GetSurfaceImage about sdl HOT 3 CLOSED

Agreed, this change sounds good. Want to submit a PR for this, including updating the documentation?

from sdl.

Okay, I have created a PR that implements what I suggested above.

I hadn't thought about the fact that that alternate images could have different aspect ratios. I guess a smaller image could technically be a better match if the aspect ratio is closer to the aspect ratio of the main surface. It also raised the question how to decide if an image is larger if the height is smaller but the width is larger or vice versa.

What I ended up doing was to calculate the size as width × height and simply compare that to see if an image is larger or smaller. I think this is probably good enough because I don't think you're supposed to use widely different aspect ratios for the alternate images and the original code didn't handle it well anyway (the scaled image always gets the aspect ratio of the main surface).

If any call to SDL_ScaleSurface fails it simply returns NULL. This is consistent with the previous version but I wasn't sure if this was the right thing to do because in another place it returns the main surface on error.

from sdl.

I changed it to return the closest image if scaling fails, but otherwise this looks good. Thanks!

from sdl.