Second colon sign in the URL break things about openbsd HOT 2 CLOSED

This is more likely a bug or misconfiguration in the code the that is using libtls - the error is caused by no server name being specified, yet verification is enabled. I believe the code in question is:

https://gitlab.com/alelec/FFmpeg/blob/master/libavformat/tls_libtls.c#L121

And in this case, with a numeric host (192.168.1.5 in your above example), it passes NULL as the server name to tls_connect_cbs, which will cause the server name not specified failure. If the IP address exists in the certificate, then it should be passed through as the server name. Otherwise, the only other option would be to disable name verification for the certificate.

For the record, tls_host_port() is not involved here - it is only called for tls_connect() and tls_connect_servername(). Also, the second colon check is very much necessary.

from openbsd.

Thanks, this's it.
One possible solution:

--- a/libavformat/tls_libtls.c  2018-02-19 18:33:28.485092988 +0300
+++ b/libavformat/tls_libtls.c  2018-02-19 22:23:09.004103503 +0300
@@ -109,7 +109,7 @@
         goto err_config;
     if (c->key_file && tls_config_set_key_file(cfg, c->key_file) == -1)
         goto err_config;
-    if (!c->verify) {
+    if (!c->verify || c->numerichost) {
         tls_config_insecure_noverifycert(cfg);
         tls_config_insecure_noverifyname(cfg);
         tls_config_insecure_noverifytime(cfg);

from openbsd.