Lower brightness per filter about red-moon HOT 6 CLOSED

As additional argument for option 1, I'll add that it suits my pattern of use rather well: When the filter turns on, I almost always set it to default and automatic brightness right away. Then later when I'm going to bed, if I want to use my phone in the dark, I'll change to my "darker" filter and manually lower the brightness.

from red-moon.

When I first implemented profiles, I thought it would only be for the colour/transparency of the filter, so I haven't made it very flexible. I agree that it is confusing that Lower brightness is under the same header, but not affected by the profile.

Option 1 seems like the best solution to me, however it will require a change in the database of the profiles. I will look into changing this database. I'm however not sure what the Lower brightness setting of the profiles the user has made in old versions should be. Should it be off for all these profiles, or should it be the value of Lower brightness that the user has set when they install the new version of Red Moon. What do you think?

from red-moon.

Having things change without taking any action (many users auto-update) is diruptive; I would use whatever the user has set when they update for all filters as the default value.

For new installs, definitely off for Default, but maybe on for Bed reading? Or we could just let the user enable it in a custom profile if they want it. I don't personally use the reading filter much so I'm not really sure if it works better with low brightness or that makes the screen too hard to see at all.

from red-moon.

Since this will require changing the format of profile storage, we should consider whether it would be better to stick with using the sharedPreferences or just migrate to a database.

from red-moon.

Looked into Android databases a little and they would be overkill for us. SharedPrefs + JSON is totally sufficient.

from red-moon.

Done in #118; will be released in v3.0.0.

from red-moon.