Giter Club home page Giter Club logo

Comments (6)

Kasijjuf avatar Kasijjuf commented on June 7, 2024

Bullet point two should already be a feature. Are you using the latest version?

from red-moon.

RomFouq avatar RomFouq commented on June 7, 2024

Automatically pausing for APKs would be awesome, since you need to pause the filter for updating apps on F-droid.

from red-moon.

raatmarien avatar raatmarien commented on June 7, 2024

Thanks for the suggestions!

  • Automatically pause when installing APKs
    Darker detects when an APK is attempting to install and temporarily pauses.

This would indeed be very useful, and I've been looking into how to accomplish this. It seems that up to Android Lollipop (API 21) it was fairly easy to get the info of the foreground app with ActivityManager.getRunningTasks, however as of API 21+ this only returns 'non sensitive' tasks, making it unusable for this purpose.

According to this StackOverflow answer a workaround on later versions of Android is using android UsageStatsManager and filter out the last used application. A problem with this approach is that UsageStatsManager isn't implemented on Samsung phones according to the comments on that question.

Lastly I'm not sure how Red Moon would register changes to the foreground activity. There doesn't seem to be a listener framework for the UsageStats or the ActivityManager and constantly polling for changes may be a drain on the battery life of a phone.

That said, I'm quite a fan of this feature. I think it would be a huge usability improvement (especially for F-Droid users). However it seems that it would be quite complex and time consuming to implement this correctly, which I don't have right now. If someone else is willing to implement this, I would love to see a pull request 😄.

  • Notification panel buttons
    Easily enable/disable the filter via a button toggle instead of having to open the application.
    (Red Moon's screenshots appear to show this functionality but it doesn't appear in Android 4.2.1 so I'm unsure if this is a bug.)

If you don't have a pause/resume button on your notification, than it is a bug. If you don't have a enable/disable button in the notification anymore, than it is intended behaviour.

I don't think a disable button is appropiate in the notification, since disabling and enabling should be a rare occurance for the normal user. If you use Red Moon once in a while, you should probably have it enabled. Disabling is meant as a way of removing all the Red Moon features for a while without uninstalling it.

  • Option to keep status bar brightness
    When enabled the filter works as usual except for over the status bar region. This is very useful for bandwidth monitoring or when apps have unclear icons.

Although I do see the use of this feature, I think it would be very rarely used. Most people will want the whole screen to be dimmed when they are using Red Moon. I also don't think adding an option for this is a good idea, since I want to avoid feature creep and I don't want to 'scare' more casual users with too many options.

from red-moon.

raatmarien avatar raatmarien commented on June 7, 2024

I'm going to move your first suggestion to a separate issue for clarity.

from red-moon.

smichel17 avatar smichel17 commented on June 7, 2024

I also do not think this is something we should add an option for. If there were a reliable way to detect whether the status bar is visible (ie, whether an app is full-screen), and just always apply the filter to the status bar at a slightly reduced level, I think that would be reasonable. But I do not think this exists.

from red-moon.

smichel17 avatar smichel17 commented on June 7, 2024

Easily enable/disable the filter via a button toggle

You should be able to do this via the notification. If you've added a widget and/or (on Android 7.0+) a quick settings tile, you can use them to toggle as well. If those aren't working, please open a bug about it :)

Don't dim the status bar

Realistically, I just don't see this ever happening. Adding an extra option for a feature that I doubt will be used by the majority of users goes against Red Moon's design goal of staying as simple as possible. So, I'm going to close this issue.

That said, if something changes and this becomes a highly requested feature, I'm happy to reconsider it. And, if it is very important to someone, I encourage your to fork Red Moon and change it so the status bar is never filtered. It would be really, really easy to make and maintain that fork, because the logic for figuring out the screen dimensions is all in one file: https://github.com/raatmarien/red-moon/blob/master/app/src/main/java/com/jmstudios/redmoon/manager/ScreenManager.kt

from red-moon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.