Translation Multilingual about mylibrenms HOT 7 OPEN

This will be great, i'm adding multi language implementation right now, once i'm finished I will be open sourcing this project.

from mylibrenms.

Great

Please open that I would like to reply with the translation.

Thank you very much!

from mylibrenms.

It's been released (thank you so much @pheinrichs :)).

@sergiolps https://github.com/pheinrichs/myLibreNMS/tree/master/src/assets/i18n Looking forward to seeing your PR :)

from mylibrenms.

I made a pull request for my dutch translation file, I did notice however that the language -tags used do not include the country/region code (for example en-US instead of just "en" ) I think it would be best to start off using those right from the start because languages can differ a lot depending on country, for example en-UK is really different from en-US while both are considered "English"

from mylibrenms.

So the code for language support takes the value before the - currently. I expect that's to simplify things as -UK and -US for the most part here will be the same.

Something like: ngx-translate/core#393 maybe. Try and use a more specific and if not fall back to the X- part?

from mylibrenms.

If ever we get another translation for multiple region codes I think we can remove the logic at that time. They'll both require an update anyway so it's not that big of an caveat.

from mylibrenms.

from mylibrenms.