Giter Club home page Giter Club logo

Comments (12)

Roshanjossey avatar Roshanjossey commented on July 22, 2024

Giving a different formatting to the misspellled word could emphasize it effectively. Especially when pointing it out in a sentence.

Underline, font-weight etc could be used.

from librelingo.

kantord avatar kantord commented on July 22, 2024

This is the component that probably needs to be modified: https://github.com/kantord/LibreLingo/blob/master/src/components/ChallengePanel.svelte

cc. @iasonasma

from librelingo.

stale avatar stale commented on July 22, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from librelingo.

sesam avatar sesam commented on July 22, 2024

How about distinguishing "Correct" from "Accepted"? As-is, the headline and the color are all the same. I think it would be worth checking if people make a bigger effort / feel greater satisfaction with making an effort with the spelling and accents if there's at least some visual difference.
The other aspect is if the coloring should be a 1:1 match to the scoring, or if there's a need to keep things simple, and maybe the first step could be just making the correction more visible. How? Bold face? Bigger? Deeper shade of green?

from librelingo.

kantord avatar kantord commented on July 22, 2024

would be worth checking if people make a bigger effort

since we lack AB tests or any tracking, there's no easy way to do that

The other aspect is if the coloring should be a 1:1 match to the scoring

I think there's no reason why it has to be a 1:1 match, I love the idea of introducing a third color! To be on the safe side, I think color should not be the only thing telling these apart. Perhaps we could even include versions of Lili?

from librelingo.

kylemumma avatar kylemumma commented on July 22, 2024

I'd love to take on this issue as my first PR

from librelingo.

kantord avatar kantord commented on July 22, 2024

@kylemumma amazing!! Go for it! Let me know if you have any questions

from librelingo.

kylemumma avatar kylemumma commented on July 22, 2024

@kantord I was able to get the typo message changed for ListeningChallenge.svelte, I also noticed that ShortInputChallenge.svelte contained spellingSuggestions as well but couldn't find anywhere that this component was used in the lessons. I went ahead and changed it for that component too but haven't been able to test that its working properly since I couldn't find anywhere that component was used. This is what the new design looks like:
typopr

from librelingo.

kantord avatar kantord commented on July 22, 2024

Hi, @kylemumma, if you have the server running locally, there is this URL that you can open (not documented yet, sorry 🤦 ). http://localhost:3000/devtools

There you should see links to examples of each challenge type used.

from librelingo.

kantord avatar kantord commented on July 22, 2024

BTW feel free to submit the PR!

from librelingo.

killuaDev avatar killuaDev commented on July 22, 2024

This is all done right?
image

from librelingo.

kantord avatar kantord commented on July 22, 2024

I think so, although there is still a lot of room for improvement here

from librelingo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.