Giter Club home page Giter Club logo

Comments (18)

Deuchnord avatar Deuchnord commented on July 22, 2024 2

While I agree that accents are important when learning languages, they become a problem when you are using a keyboard that makes them inaccessible.

For instance: I'm using a French keyboard, which gives you (logically) an advantage to use accents in French (éèêëàôöùûü), but (still logically) does not provide an easy way to type the Spanish-specific ones, nor the German-specific ß letter (for example). Linux users are a little advantaged here because they can configure the Compose key on their keyboard to fix most of these problem (e.g. ó = Compose + ' + o), but AFAIK Windows and Mac users are still wronged.

IMO it might be great to add buttons in the interface to append those accents in the field.

from librelingo.

kantord avatar kantord commented on July 22, 2024 2

Is this intended behaviour or are you normalising the string to heavily before comparison?

There is some normalization going on for answers, yes. The reason why it's accepted isn't the normalization though. Rather, a certain edit distance is allowed. See: https://github.com/kantord/LibreLingo/blob/master/src/components/ShortInputChallenge.svelte#L28

Small typos (and possibly even accent mark and punctuation mistakes) should be accepted, because it would be annoying to have to try again many times for tiny mistakes.

In the case of such typos, the answer is accepted, but the user is still alerted of the error, see:

Screenshot_2020-02-09 LibreLingo - learn animals in Spanish for free

I think that's a good solution, but maybe the design is not good here? Maybe it could call for the user's attention a bit more.

from librelingo.

ryliejamesthomas avatar ryliejamesthomas commented on July 22, 2024 1

For me it marks it as correct, but acknowledges that I left out the accent.

Correct solution!

You made a small error. Correct spelling: león

from librelingo.

kantord avatar kantord commented on July 22, 2024 1

IMO it might be great to add buttons in the interface to append those accents in the field.

YES

from librelingo.

pinkprius avatar pinkprius commented on July 22, 2024 1

It's this way because that's how Duolingo does it (I think).
I think it works fine this way, because it makes this app a very fun experience, it's very easy so people keep going. This is part of the huge success of Duolingo I believe.

from librelingo.

Deuchnord avatar Deuchnord commented on July 22, 2024 1

The alert is great, but not really adapted to wide screens. It might be better to move it closer to the form on these devices to make it more visible and thus, more accessible, mightn't it?

from librelingo.

kantord avatar kantord commented on July 22, 2024 1

I created a new issue regarding the layout issue on wide screens: #81

cc. @Deuchnord

from librelingo.

igalic avatar igalic commented on July 22, 2024

this is all considerably easier on a mobile platform where adding a new keyboard layout and seeing what keys you're typing on is all very easy

this is me assuming you can see.
i don't know which accessibility affordances android and iOS have for the actual keyboard.

from librelingo.

kantord avatar kantord commented on July 22, 2024

@all-contributors please add @schmittlauch for ideas

from librelingo.

allcontributors avatar allcontributors commented on July 22, 2024

@kantord

I've put up a pull request to add @schmittlauch! 🎉

from librelingo.

kantord avatar kantord commented on July 22, 2024

@all-contributors please add @Deuchnord for ideas

from librelingo.

allcontributors avatar allcontributors commented on July 22, 2024

@kantord

I've put up a pull request to add @Deuchnord! 🎉

from librelingo.

schmittlauch avatar schmittlauch commented on July 22, 2024

@kantord

maybe the design is not good here? Maybe it could call for the user's attention a bit more.

Definitely, the current design is so subtle that I didn't notice at all, being just a small line of text at the bottom edge of a maximised window on a large screen.
I suggest using a separate design and not treat them as correct but corretctly-ish. So let them fall in a different category then correct or incorrect and maybe represent them in yellow. It should be clearly noticeable that the answer was not totally correct.

from librelingo.

schmittlauch avatar schmittlauch commented on July 22, 2024

@pinkprius You already have to know that you are looking for a small correction notification, unless you won't notice it.
Screenshot_20200210_164959

from librelingo.

pinkprius avatar pinkprius commented on July 22, 2024

I agree, but I don't think that's necessarily bad. Maybe a system where you have stars depending how correct your answer is would make it clear?

from librelingo.

kantord avatar kantord commented on July 22, 2024

this is me assuming you can see.
i don't know which accessibility affordances android and iOS have for the actual keyboard.

it's indeed an important point. Accessibility is very important. I hope someone with knowledge about it will take interest in contributing. I'll create a label for issues that are concerning accessibility

from librelingo.

kantord avatar kantord commented on July 22, 2024

@pinkprius

I agree, but I don't think that's necessarily bad. Maybe a system where you have stars depending how correct your answer is would make it clear?

I don't think there would be many different levels of correctness, although a complicated system might be devised for letting the user know about different errors.

Still, differentiating between a wholly correct error and an almost correct makes sense.

Making the color yellow might makes sense, as @schmittlauch says, but I think a slightly milder solution would be preferred

edit: I made a new issue for this #82

from librelingo.

kantord avatar kantord commented on July 22, 2024

Solved in #167

from librelingo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.