Comments (3)
Interesting. Thanks for the report. The third thread appears to be the thread for the PLC connection. It should have been set to terminate, but it looks like the timing/coordination is not working right. This might take me some time to debug. I am going to mark this as a bug for now. Thanks again!
from libplctag.
diff --git a/session.c b/session.c
index 3c36271..60dc163 100644
--- a/session.c
+++ b/session.c
@@ -71,7 +71,7 @@
#define SOCKET_WAIT_TIMEOUT_MS (20)
#define SESSION_IDLE_WAIT_TIME (100)
-
+volatile int ab_session_terminating = 0;
static ab_session_p session_create_unsafe(const char *host, const char *path, plc_type_t plc_type, int *use_connected_msg, int connection_group_id);
static int session_init(ab_session_p session);
@@ -141,6 +141,8 @@ void session_teardown()
{
pdebug(DEBUG_INFO, "Starting.");
+ ab_session_terminating = 1;
+
if(sessions && session_mutex) {
pdebug(DEBUG_DETAIL, "Waiting for sessions to terminate.");
@@ -173,6 +175,8 @@ void session_teardown()
session_mutex = NULL;
}
+ ab_session_terminating = 0;
+
pdebug(DEBUG_INFO, "Done.");
}
@@ -1031,7 +1035,7 @@ THREAD_FUNC(session_handler)
pdebug(DEBUG_INFO, "Starting thread for session %p", session);
- while(!session->terminating) {
+ while(!session->terminating && !ab_session_terminating) {
/* how long should we wait if nothing wakes us? */
wait_until_time = time_ms() + SESSION_IDLE_WAIT_TIME;
@@ -1321,6 +1325,9 @@ THREAD_FUNC(session_handler)
purge_aborted_requests_unsafe(session);
}
+ if (ab_session_terminating)
+ session_destroy(session);
+
THREAD_RETURN(0);
}
I just added an ab_session_terminating flag which will be set in session_teardown and ends all remaining THREAD_FUNCs with additionally destroying the session. Now plctag_shutdown never hangs...
from libplctag.
I am just getting back to you, sorry for the delay!
I am not sure why adding an additional flag would make this work. The existing session->terminating
flag should be sufficient.
I have not been able to reproduce this. Are the steps here:
- let libplctag connect to a PLC.
- interrupt the connection (by turning off the PLC? by pulling the Ethernet cable?)
- terminate the session by closing the last tag.
Is that correct?
from libplctag.
Related Issues (20)
- Symbol ID Addressing and quote request for additions to the library HOT 11
- Message packing on OmronNJ/NX beyond max response size HOT 2
- Standalone website to host documentation HOT 4
- Write is not working for SINT and USINT (1 byte) datatype for Omron NX/NJ PLC HOT 5
- MSR is not working for modbus_tcp protocol using libplctag library HOT 3
- MinGW timeapi.h issue HOT 4
- ASP.Net error HOT 2
- Parsing of port/link pairs is not correct in all cases HOT 5
- ControlNet is limited to 504 byte request/response packet sizes HOT 1
- Read/writing OmronNJ/NX TIME and DATE_AND_TIME data HOT 14
- Support data files for input and output without the data file numbers HOT 1
- Support for Omron NX/NJ variable listing HOT 214
- Packet sizes for Omron do not match documentation
- More exposure of internal tag information needed to solve BOOL array problem HOT 1
- Known Omron problems
- Support Omron-style fragmented reads and writes
- split Omron code out from generic/Rockwell CIP code.
- redo start_read()/start_write() to use data segment descriptors.
- Refactor the existing CIP/Rockwell code to eliminate more of the duplication and split out common versus specific code.
- Document all attributes in one place
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libplctag.