Giter Club home page Giter Club logo

Comments (3)

Stebalien avatar Stebalien commented on June 12, 2024 1

Especially since it creates a whole thread.

It creates a goroutine, which is much lighter weight than a thread. E.g., if you look at the go standard library, the HTTP library will create a new goroutine per request.


However, I do generally agree. This kind of situation is why we introduced the event bus. The correct fix here is to:

  1. Remove the notifee system entirely. Well, likely deprecate it for now then remove it later.
  2. Emit an event using the host.

from go-libp2p.

marten-seemann avatar marten-seemann commented on June 12, 2024

See #1221.

from go-libp2p.

master255 avatar master255 commented on June 12, 2024

I just deleted the "go" in my Libp2p and continued writing code.
And your Libp2p still has the creation of goroutine. And other discovery modules do not have goroutine creation, when passing peer.
Your Libp2p code is not fixed, but mine is. It's my role to tell you about the problem. But I noticed you don't listen to me at all. It's my duty to give you a chance. How you use it is up to you.

from go-libp2p.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.