Comments (1)
The ThreadPool being stuck I encountered, It was never stopping, it seems like the issue has to do with the scope of the status_locks, if you notice the Stop() method:
int ThreadPool::Stop() {
std::unique_lock status_lock(status_wait_mutex); // <- this will lock the entire scope of Stop(), after notifying,
// the mutex is still held during the notification which will not give the threads a chance to acquire it and get the notification (in the thread loop)
if (STOP == status) {
return -1;
}
status = STOP;
status_wait_cond.notify_all();
task_cond.notify_all();
for (auto& i : threads) {
if (i.thread->joinable()) {
i.thread->join();
}
}
threads.clear();
cur_thread_num = 0;
idle_thread_num = 0;
return 0;
}
I think it should be:
int ThreadPool::Stop() {
{
// lock only this scope to ensure that the mutex is not held during the notification process, allowing the waiting threads to acquire it immediately after being awakened
std::unique_lock status_lock(status_wait_mutex);
if (STOP == status) {
return -1;
}
status = STOP;
}
status_wait_cond.notify_all();
task_cond.notify_all();
...
}
I tried that locally and it seems the thread pool is waiting and stopping normally so far, I will test with more use cases and get back to you if there is another issue.
from cpr.
Related Issues (20)
- Link error when setting -DCMAKE_BUILD_TYPE=Debug HOT 4
- SetUrl() does not update new URLs properly within same Session() object HOT 1
- SSL certificate pinning HOT 3
- Question: Is `WriteCallback` asynchronous? HOT 1
- cpr::Buffer data lifetime question HOT 4
- constexpr methods for some string-like types HOT 1
- Add support for identifying whether a Session is currently busy or not HOT 1
- zlib ignores --prefix/CMAKE_INSTALL_PREFIX when using cpr as external dependency HOT 2
- Link error when creating a cpr::Header, segment fault when making cpr::Get request HOT 1
- Question: Does cpr support ftp? HOT 1
- Confused on something HOT 3
- Call of overloaded ‘SetOption(std::__cxx11::basic_string<char>)’ is ambiguous HOT 1
- 13.2.0 gcc compiler, vcpkg and cpr: compilation error. HOT 7
- cpr::ThreadPool high CPU usage when Paused HOT 4
- Interceptors are single-shot
- async callback with highest performance?
- Possible race condition in singleton class GetInstance() function HOT 1
- cpr use system default curl? HOT 8
- parallelized http get/post request with trying best to reuse connections? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cpr.