Giter Club home page Giter Club logo

Comments (4)

humancalico avatar humancalico commented on July 16, 2024

@qmonnet It would be a great UX improvement if it just shows an error that this operation is not supported for now instead of showing an empty map

from bpftool.

qmonnet avatar qmonnet commented on July 16, 2024

You mean if trying bpftool map event_pipe id N with map of id N being a BPF ring buffer? I haven't tried it, but I would expect bpftool to display an error, given that we have the following in map_perf_ring.c:

	if (map_info.type != BPF_MAP_TYPE_PERF_EVENT_ARRAY) {
		p_err("map is not a perf event array");
		goto err_close_map;
	}

Or can you provide more details on what you've tried and observed?

from bpftool.

humancalico avatar humancalico commented on July 16, 2024

@qmonnet I wasn't aware of event_pipe. I was directly trying to dump data using bpftool map dump id N (N being the BPF ring buffer)

from bpftool.

qmonnet avatar qmonnet commented on July 16, 2024

OK I see, yes it would make sense to avoid displaying something empty in that case.

from bpftool.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.