Comments (3)
Hi, thanks a lot for the report!
Both issues are bugs in the feature detection. It looks that clang
does not need the flags telling to the linker what libraries to use, and this results in warnings that break detection due to the use of -Werror
. Adding Wno-unused-command-line-argument
seems to fix it indeed.
I don't directly experience the issue with the echo
on my setup, it “works fine for me”. But echo
is not known to be portable, and I'm ready to believe that the current code breaks on other environments. I observed that the $(shell echo)
invocation calls /bin/sh
(dash
for me) which is supposed to use /usr/bin/echo
, but it seems that in some cases (including the default case for me, where the current code works), some built-in echo
is used instead. I think it's some built-in from make, but didn't manage to confirm it. Anyway. Adding -e
is not a solution though: it breaks on my setup. I think we'll switch to using printf
instead of echo
, hopefully it will be more stable.
If you have a moment, could you please check whether the changes in #5 fix the build on your setup?
from bpftool.
Hi, thanks a lot for the report!
Both issues are bugs in the feature detection. It looks that
clang
does not need the flags telling to the linker what libraries to use, and this results in warnings that break detection due to the use of-Werror
. AddingWno-unused-command-line-argument
seems to fix it indeed.I don't directly experience the issue with the
echo
on my setup, it “works fine for me”. Butecho
is not known to be portable, and I'm ready to believe that the current code breaks on other environments. I observed that the$(shell echo)
invocation calls/bin/sh
(dash
for me) which is supposed to use/usr/bin/echo
, but it seems that in some cases (including the default case for me, where the current code works), some built-inecho
is used instead. I think it's some built-in from make, but didn't manage to confirm it. Anyway. Adding-e
is not a solution though: it breaks on my setup. I think we'll switch to usingprintf
instead ofecho
, hopefully it will be more stable.If you have a moment, could you please check whether the changes in #5 fix the build on your setup?
check in my env, it's ok.
thank your replay.
... libbfd: [ on ]
... disassembler-four-args: [ OFF ]
... zlib: [ on ]
... libcap: [ OFF ]
... clang-bpf-co-re: [ on ]
from bpftool.
And thank you for testing :) Merged now.
from bpftool.
Related Issues (20)
- `mount_bpffs_for_pin()`: if passing a directory, mount bpffs on this dir, not on parent dir HOT 22
- Print error and exit instead of diplaying an empty map for unsupported map types
- Fix weird indent in documentation HOT 1
- streamline bpftool net dump HOT 1
- "make install" for man pages stops. HOT 1
- Wrong callq address displayed HOT 5
- Error: No JIT disassembly support HOT 2
- Make error formatting consistent in libbpf and bpftool
- Skeletons: Improve support for 32-bit architectures
- Skeletons: Support cross-compiling towards architectures with different endianness HOT 1
- Add line annotations for control flow graph
- Zsh completion for bpftool
- can't mount BPF file system to pin the object HOT 2
- bpftool v6.7.0 load xdp program on Ubuntu 16.04 kernel 4.15.0-99-generic HOT 23
- Problem with Compilation of bpftool HOT 4
- Improve info for some link types in `bpftool link list`
- Update bpftool-cgroup documentation w.r.t. attach types HOT 1
- Fix LLVM detection in kernel repository HOT 1
- Support probing for kfuncs availability HOT 7
- “Fallthrough”: Replace comment by dedicated attribute HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bpftool.