Giter Club home page Giter Club logo

Comments (24)

rascalnag avatar rascalnag commented on August 29, 2024 1

Okay, that explanation makes sense. I’ll give the updated version a go tonight, thank you!

from deferred.

rascalnag avatar rascalnag commented on August 29, 2024 1

All looked good! Also loaded up a heavier modset including TUFX, Scatterer, Volumetrics, Parallax, and Restock. Found nothing wrong.

from deferred.

LGhassen avatar LGhassen commented on August 29, 2024

This is indeed not reproducible on my machine with a clean install or otherwise (nvidia 2080 super), let me know if it doesn't happen with the 1660 ti.
I saw no issues in the log as well (thanks for testing it on a minimal install btw).

from deferred.

rascalnag avatar rascalnag commented on August 29, 2024

It still happens, which I guess is good news in that it's not a vendor thing but bad news in that I don't know what to try next! Hmmm... I'm trying to think if there's any wayward bits of KSP anywhere that might be harder to get to and clear. Something cached somewhere? Or maybe something with unity? Really funky. I will keep digging. Unity shenanigans strike me as plausible given the fresh KSP install...

from deferred.

HarlanWang avatar HarlanWang commented on August 29, 2024

I encountered the same issue when installing deferred and mk1-2 iva replaced by aset.Only installing dependencies such as Harmony2 will not result in such a situation

from deferred.

LGhassen avatar LGhassen commented on August 29, 2024

@HarlanWang he's not using any of that

from deferred.

rascalnag avatar rascalnag commented on August 29, 2024

What’s interesting is I used to have ASET, but yeah, this is all fresh now. I’ll try deleting stuff in squad and have steam verify it back maybe? Not sure why that would be affected anyway or why it would still be sticky, but no harm trying.

from deferred.

LGhassen avatar LGhassen commented on August 29, 2024

I will give the 'MK1-2' IVA Replacement by ASET mod a test

from deferred.

rascalnag avatar rascalnag commented on August 29, 2024

Did another fresh install and went with manual installation over CKAN. Still no luck. I've also tried compiling the shaders myself, which also did not work. Tried deleting and verifying squad files. Tried -force-opengl, -force-glcore, -force-d3d12/11, same result.

Is it apparent what the misbehaving shader in question is? If so I can try to tinker with things and experiment.

from deferred.

LGhassen avatar LGhassen commented on August 29, 2024

Is it apparent what the misbehaving shader in question is? If so I can try to tinker with things and experiment.

No, unless you take a renderdoc capture and send it

from deferred.

rascalnag avatar rascalnag commented on August 29, 2024

Okay, I’ll try renderdoc tonight or tomorrow. Hopefully things finally become clearer.

from deferred.

LGhassen avatar LGhassen commented on August 29, 2024

I've installed the mk1-2 iva replacement with ASET and I'm not getting this issue

image

from deferred.

rascalnag avatar rascalnag commented on August 29, 2024

I just had the general ASET packs (which may include that) but overall yeah, not sure it’ll be reproducible. I should be able to get some time late tonight to use renderdoc… fingers crossed something pops up to diagnose this. It’s probably on my end somehow but I haven’t the slightest idea what it could be.

Another thing I could maybe try is using my Ubuntu partition. That should fully isolate me from any weird sticky issues that might be causing this. If that works, maybe my windows installation just needs to get slapped around a bit…

from deferred.

rascalnag avatar rascalnag commented on August 29, 2024

image

Captured this pixel history in renderdoc. looks like the colors are correct until that final pass, then it's just all white. This capture, plus another from the mk1 pod, linked below. Going to try to install ksp and deferred in ubuntu now...

https://drive.google.com/file/d/1EDm__guLyxZkdCE_LbQZC2vQIRYn7IeY/view?usp=drive_link

from deferred.

rascalnag avatar rascalnag commented on August 29, 2024

The problem followed me to Ubuntu... now I'm really at a loss. Should be totally clean there. I mean... could it be a CPU thing (5800x3D)? Just trying to isolate some sort of common factor...

from deferred.

LGhassen avatar LGhassen commented on August 29, 2024

It's likely in the install itself not in the hardware. I'll take a look at the renderdoc capture, thanks a lot for providing it.

from deferred.

LGhassen avatar LGhassen commented on August 29, 2024

Ok I got this to happen today. If you install tufx and enable hdr (or use any profile with hdr enabled) it fixes it. I'm looking into it.

from deferred.

rascalnag avatar rascalnag commented on August 29, 2024

No problem, glad to provide info. And that’s good to hear! I will be able to verify that fix after work. Fingers crossed. If there’s anything I can test or do to make tracking down why that happens in the first place easier just let me know.

from deferred.

LGhassen avatar LGhassen commented on August 29, 2024

@rascalnag I think this should fix it (both with and without HDR), https://drive.google.com/file/d/1lK7qUlanT7praEztntzdVBnpvjJCfg0M/view?usp=sharing

Can you test it? I haven't tested in depth. Also if you can just play with it for a while as you normally play and watch out for any issues

from deferred.

rascalnag avatar rascalnag commented on August 29, 2024

Awesome, and will do! I’ll run a few missions tonight on a basic install and check the windows a bunch throughout.

from deferred.

rascalnag avatar rascalnag commented on August 29, 2024

Windows are fixed! Though I have noticed some lighting differences overall:

Old:
image

New:
image

But it doesn't really look broken. In fact I think the old version was actually looking a bit off. It might have just been something bugged related to this issue that I did not notice until this comparison. Tinkering with the cfg's ambient settings helped tone it down a little. I assume this is something that also will change when I install more graphical mods and TUFX and the output is tweaked accordingly.

Lastly, I do notice this flickering when around low orbit (or just zooming the camera out to around this height and moving it around):

https://streamable.com/ho3rro

But I went back and found the released version also appears to do it. So not an effect of this fix. If you're familiar with it, I'd be curious if there are any mitigations. But overall, that's another issue...

Anyway, thank you very much for all the time spent fixing this! I did not expect it to become such a rabbit hole. Very glad to be able to see out of windows again. If you don't notice anything concerning with the lighting change, probably can be closed!

from deferred.

LGhassen avatar LGhassen commented on August 29, 2024

There were other changes in the meantime, small fixes to the normals around KSC, fixes to the color space conversion, which might affect the colors a bit. It shouldn't be too noticeable of a difference but if you say it looks better then that's fine.

Concerning the other issue, that's around the transition from local to scaled space (160 km) which the stock ocean doesn't handle well in deferred (and which I'm not going to bother fixing). If you use scatterer then everything will work correctly and you won't get that pop (also lighting will look much better).

Thanks a lot for testing it. I consider this fixed but will only release publicly in a few days just to have a bit more time to play with it and make sure there no hidden issues.

from deferred.

LGhassen avatar LGhassen commented on August 29, 2024

@rascalnag I've actually updated the fix because I noticed some issues with that version with mods that use depthMasks like restock. Should be much more robust now: https://drive.google.com/file/d/1yuAuMGA7pe6vt8CUbOzzu5w4EJ7o7MGP/view?usp=sharing

from deferred.

LGhassen avatar LGhassen commented on August 29, 2024

This is publicly released now

from deferred.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.