Giter Club home page Giter Club logo

Comments (3)

LGatodu47 avatar LGatodu47 commented on June 25, 2024

Hello,
First I'd like to thank you for your elaborated feedback. Here are my thoughts on the points you mentionned:

For a good while I thought it could only view and not manage screenshots

make it somehow clear that files can be right-clicked. If just by pointing it out in the mod description

I think you're definitely not the first one to encounter this issue with the mod. Indeed there's nothing indicating the existence of a right-click menu, and for that I thought of adding a discrete tooltip hinting this when a screenshot is hovered for a few seconds. But I might also do as you suggest and add it to the mod description.

allow right click actions on a large preview screenshot instead of only the small one

I thought of adding this during the development process and I found it to be a little confusing. So I don't really know if i'll add this, I will test first.

in the right click menu, allow clicking on the text itself instead of only the icons.

Same here, i'm not sure it will make the menu objectively better. I will test this too.

allow for shortcut ctrl-c to copy an image to clipboard

For me there wasn't any convenient way to add ctrl-c shortcut into the screenshot manager, but after thinking more about it, I realised that I could make it so ctrl-c would copy directly the hovered screenshot.

allow for multi selection of images with shift/control clicking to delete/copy/open multiple images at once

There's a plan for a fast-delete feature however I didn't start working on it. Also copying multiple images to the clipboard isn't possible to my knowledge and opening multiple images at the same time could be overwhelming especially if not done intentionally.

add delete, copy, edit menu buttons to the full size viewers for people who missed the right click option

That would be a more preferable substitute for your second suggestion.

I would also heavily appreciate a release of the new additions for 1.20.1

I've been thinking about bringing new changes to older versions, and I think once I'll be over with the state of the mod on 1.20.4, I'll port everyting to minecraft 1.20.1.

Hope this could help, have a nice day!

from screenshotviewer.

HB-Stratos avatar HB-Stratos commented on June 25, 2024

Glad to hear my feedback reached ears that were willing to listen!
I have some thoughts to some of your comments, which I have detailed below.

I think you're definitely not the first one to encounter this issue with the mod. Indeed there's nothing indicating the existence of a right-click menu, and for that I thought of adding a discrete tooltip hinting this when a screenshot is hovered for a few seconds. But I might also do as you suggest and add it to the mod description.

A delayed tooltip feels a bit counter intuitive, but then again that constantly appears also feels like it'd be more in the way than helpful. The top right corner already tells players that they can zoom in and out with CTRL, so perhaps adding it there in some way may be fitting

Same here, i'm not sure it will make the menu objectively better. I will test this too.

I feel having the entire line clickable would be more consistent with user expectations. It matches windows default menus and just about every other right click menu I can currently think of. I also find that reducing the clickable target area when more room is available just makes unnecessarily harder to use.

For me there wasn't any convenient way to add ctrl-c shortcut into the screenshot manager, but after thinking more about it, I realised that I could make it so ctrl-c would copy directly the hovered screenshot.

If no select image function exists this does feel like the most sensible implementation. Perhaps a toast that pops up informing the user of a successful copy would be helpful too.

There's a plan for a fast-delete feature however I didn't start working on it. Also copying multiple images to the clipboard isn't possible to my knowledge and opening multiple images at the same time could be overwhelming especially if not done intentionally.

I am relatively sure it is possible to copy multiple images into the same clipboard, though this appears to work through a different mechanism than copying one image. Prism Launcher is capable of doing this, the way it is specified there is as "copy image" to copy an image, and "copy file(s)" for pushing multiple images to clipboard. For opening multiple images at once I agree that could be overwhelming, perhaps opening should not support multi-selection, or at least pop up a warning asking the user to confirm if they wish to open 20 instances of windows photos.

I've been thinking about bringing new changes to older versions, and I think once I'll be over with the state of the mod on 1.20.4, I'll port everything to minecraft 1.20.1.

Great to hear! With the massive technical changes in 1.20.5 I'm expecting that updating mods will take longer than usual this time, so having a 1.20.1 version is vital.

from screenshotviewer.

LGatodu47 avatar LGatodu47 commented on June 25, 2024

Hello,
I incorporated some the changes you mentionned:

  • I added the toast appearing when copying a screenshot. This is indeed a very good idea.
  • I made the entire line clickable for the properties menu, and it can be reverted to how it was before with a config option. I agree on the fact that it looks more consistent, but I personnally prefer the old look and I think it's just a personal preference overall so it doesn't really matter.

Regarding the tooltip, I'll leave it there, as it is an easy way to hint possible interactions, doesn't get too much in the way (as it has transparency and disappears when moving to another screenshot), and can be disabled in the config.

And finally, for copying multiple images/opening multiple images, I think I won't implement it, because you can just open the screenshot folder and copy/open from the file explorer.

Anyways from now on I'll focus on backporting the mod. Feel free to suggest more things or close this issue.

from screenshotviewer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.