Giter Club home page Giter Club logo

Comments (8)

lgallard avatar lgallard commented on May 31, 2024 2

@philippta I like the idea. I'll include in the next release!

from terraform-aws-cognito-user-pool.

pb0101 avatar pb0101 commented on May 31, 2024 1

https://docs.aws.amazon.com/cognito/latest/developerguide/user-pool-settings-deletion-protection.html

may be add support for this

from terraform-aws-cognito-user-pool.

lgallard avatar lgallard commented on May 31, 2024

@philippta this issue was addressed in release 0.11.0

from terraform-aws-cognito-user-pool.

lgallard avatar lgallard commented on May 31, 2024

@philippta I had to revert it due to #54. As soon as it fixed in the provider I will include @Waschnick implementation

from terraform-aws-cognito-user-pool.

Waschnick avatar Waschnick commented on May 31, 2024

@philippta I had to revert it due to #54. As soon as it fixed in the provider I will include @Waschnick implementation

Hey @lgallard sorry if I hadn't tested the changes enough. Your link is not correct, can you tell me what the issue was?

from terraform-aws-cognito-user-pool.

lgallard avatar lgallard commented on May 31, 2024

@Waschnick I reverted it because there were reports about people unable to do plan/apply because of prevent_destroy using a variable. The root cause seem to be reported here in the AWS provider for other resources as well.

You are right, the correct issue where it was reported in this project was #58!

And no worries, I will include these changes as soon as the iss is fixed in the provider. Thanks for the PR!!

from terraform-aws-cognito-user-pool.

AutomationD avatar AutomationD commented on May 31, 2024

This is a pretty critical issue to us as well.

@lgallard do you think we could create some special fork/version history that would have it enabled by default statically? Maybe 10.18.2 for the most recent one or maybe you'd be interested to maintain a fork like terraform-aws-cognito-user-pool-protected?

from terraform-aws-cognito-user-pool.

lgallard avatar lgallard commented on May 31, 2024

@pb0101 It seems is not yet implemented in the Terraform provider, or is not documented here , and there's a open issued about using variables to handle this here.

As soon it implemented in the provider, I'll be more that happy to include it

from terraform-aws-cognito-user-pool.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.