username_configuration case_sensitive about terraform-aws-cognito-user-pool HOT 10 CLOSED

@Modestasthinkt try defining var.case_sensitive with the same value it tries to replace.

from terraform-aws-cognito-user-pool.

Even with the same value, terraform wants to force replacement because the entire username_configuration block is absent (it's optional and the resource was originally provisioned via the console). Would converting username_configuration to a dynamic block solve this?

Maybe something like this:

locals {
  username_configuration_attributes = length(var.username_configuration) == 0 ? {} : {
    case_sensitive = lookup(var.username_configuration, "case_sensitive", true)
  }
  username_configuration = length(local.username_configuration_attributes) == 0 ? [] : [local.username_configuration_attributes]
}

dynamic "username_configuration" {
  for_each = local.username_configuration
  content {
    case_sensitive = lookup(username_configuration.value, "case_sensitive")
  }
}

from terraform-aws-cognito-user-pool.

@Modestasthinkt @bentlema I couldn't reproduce the issue. I created a new user pool from the console and then imported with Terraform.

Can you give me more information?

• AWS provider version?
• Terraform version?

from terraform-aws-cognito-user-pool.

@bentlema I can add the suggested code, but username_configuration is just one bock definition.

from terraform-aws-cognito-user-pool.

In my case, I'm using: Terraform v0.12.29, provider.aws v2.70.0

About that code snippet: I was just looking for a way to omit the username_configuration block entirely and it seems like the dynamic block achieves that when given an empty list, but I didn't spend too much time on it...could be a better way I'm missing.

Also, I had imported a user pool that was created over a year ago. Let me see if it does the same thing with a new pool...

from terraform-aws-cognito-user-pool.

@eduzera I see...I'm adding your code to avoid defining username_configuration

from terraform-aws-cognito-user-pool.

Yeah, same here, I was unable to repo on a newly-created user pool via the console.

But, I did find a case where I could repo the issue:

1. Create a new user pool via terraform using resource aws_cognito_user_pool directly and omitting the username_configuration block
2. Build out a new root module using this module & import the pool created in the previous step
3. Run a terraform plan, and you'll see that it wants to destroy/re-create due to the case_sensitive option

from terraform-aws-cognito-user-pool.

@bentlema you can try with this branch https://github.com/lgallard/terraform-aws-cognito-user-pool/tree/dynamic_username_configuration_block

If you omit the user_configuration variable it shouldn't create the block (I used you code and jus rename the local).

If it works for you, I merge it after updating the README and the examples.

from terraform-aws-cognito-user-pool.

Thanks @lgallard ! Tested it, and works great.

from terraform-aws-cognito-user-pool.

@Modestasthinkt @bentlema release 0.6.0 fixes this issue!

from terraform-aws-cognito-user-pool.