Giter Club home page Giter Club logo

Comments (8)

lfparis avatar lfparis commented on August 20, 2024

Addressed in PR #12

from airbase.

cancan101 avatar cancan101 commented on August 20, 2024

Is #12 the right number here?

from airbase.

lfparis avatar lfparis commented on August 20, 2024

Thanks for flagging the correct PR is #22

from airbase.

cancan101 avatar cancan101 commented on August 20, 2024

Pt 1 above, does not look to have been addressed:

The raised error does not indicate to the user which error response code was received from Airtable
Problem 1 can be addressed by passing the response / response code to raise_or_log_error (when it exists) and attaching that to the AirbaseException or the log statement.

from airbase.

lfparis avatar lfparis commented on August 20, 2024

So, while the raise_or_error() method does not receive the response object, it can receive a string with the response code and error information.
Let me know your thoughts on this implementation?

airbase/airbase/airtable.py

Line 159 in a9e4c44

error_msg = f"{res.status}: Failed to get bases -> '{data.get('error').get('type')}'" # noqa:E501

from airbase.

cancan101 avatar cancan101 commented on August 20, 2024

It might be nice to have something more semantic than just the string to make handling the different error types differently by the caller easier.

from airbase.

lfparis avatar lfparis commented on August 20, 2024

@cancan101 Please review PR #23

from airbase.

lfparis avatar lfparis commented on August 20, 2024

Resolved in PR #23

from airbase.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.