Comments (8)
Addressed in PR #12
from airbase.
Is #12 the right number here?
from airbase.
Thanks for flagging the correct PR is #22
from airbase.
Pt 1 above, does not look to have been addressed:
The raised error does not indicate to the user which error response code was received from Airtable
Problem 1 can be addressed by passing the response / response code to raise_or_log_error (when it exists) and attaching that to the AirbaseException or the log statement.
from airbase.
So, while the raise_or_error()
method does not receive the response object, it can receive a string with the response code and error information.
Let me know your thoughts on this implementation?
Line 159 in a9e4c44
from airbase.
It might be nice to have something more semantic than just the string to make handling the different error types differently by the caller easier.
from airbase.
@cancan101 Please review PR #23
from airbase.
Resolved in PR #23
from airbase.
Related Issues (11)
- Odd implementation for exponential backoff HOT 4
- Allow setting timeout on the ClientSession HOT 2
- No way to tell if get_records ran into an error HOT 2
- Error in delete row HOT 2
- Remove requirement on `async with Airtable()` HOT 1
- Return new record on table insert HOT 1
- About logger info HOT 1
- Issues with metadata API HOT 3
- airbase conflicts with another repo HOT 6
- No option to use sort when using get_records function HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from airbase.