Giter Club home page Giter Club logo

Comments (5)

rsarky avatar rsarky commented on July 25, 2024 1

Ah. Should probably have checkout the next branch before submitting the fix
My bad

from pasta.

rralf avatar rralf commented on July 25, 2024

Yep yep yep, as mentioned in the other thread, you're totally right.

But look on the next branch, I already addressed this issue: a25ee74

from pasta.

rsarky avatar rsarky commented on July 25, 2024

Although I still feel the if else ladder could be refactored to read a little better. Could you take a look at the PR referring this issue

from pasta.

rralf avatar rralf commented on July 25, 2024

Go ahead! I guess we can close this issue for the moment, right? (I'm loosing overview ;-) )

from pasta.

rsarky avatar rsarky commented on July 25, 2024

Haha yes. Closing

from pasta.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.