Giter Club home page Giter Club logo

Comments (12)

ciozi137 avatar ciozi137 commented on August 13, 2024 1

@Monkeymerlot I'm working on this. Just wanted you to be aware

from asylum-api.

ciozi137 avatar ciozi137 commented on August 13, 2024 1

Yes sorry typo in GitHub. We made this work on Cypher with code hotfix

from asylum-api.

ciozi137 avatar ciozi137 commented on August 13, 2024

Confusingly, GV() means "Get Value" and reads the value from the Global Variable Table.
image
image

from asylum-api.

ciozi137 avatar ciozi137 commented on August 13, 2024

image

from asylum-api.

Monkeymerlot avatar Monkeymerlot commented on August 13, 2024

OK it should be really easy to make the change. You should be able to only change "Asylum_Driver_GetLVDTParameters.vi" as this is the only place that is calling the X(Y)LVDT parameters that was causing the issue. It would be best build a unit testable "build" function that ensures the proper format of the string before it gets sent to the Igor API if you wanted to be consistent with the rest of the driver. The tests are in the Asylum API Project.

from asylum-api.

ciozi137 avatar ciozi137 commented on August 13, 2024

Hi @Monkeymerlot correct that is where the LVDT parameters are retrieved. However it's a little more complicated because I can't just change Build Read Value because it appears that td_ReadValue is still needed in some other places, OR the names in the tables are similar but slightly different.
For example:

  • td_ReadValue("XLVDT Sense") ✔️
  • GV("XLVDT Sens") ☹️
  • GV("XLVDTSens") ✔️ [no space!]

from asylum-api.

ciozi137 avatar ciozi137 commented on August 13, 2024

It's not a big deal, I just need to make a new subVI for "read value" that is distinct from "td_read value". I should be able to get to it this morning

from asylum-api.

Monkeymerlot avatar Monkeymerlot commented on August 13, 2024

I was thinking that you would make a new functionality called "GetValue" and then use the GV(...) like I do with the td_readvalue, and then replace that in the VI I mentioned above.

from asylum-api.

ciozi137 avatar ciozi137 commented on August 13, 2024

@Monkeymerlot yes exactly

from asylum-api.

Monkeymerlot avatar Monkeymerlot commented on August 13, 2024

Check out https://github.com/levylabpitt/Asylum-API/tree/GetValue

from asylum-api.

ciozi137 avatar ciozi137 commented on August 13, 2024

This look great thanks

from asylum-api.

Monkeymerlot avatar Monkeymerlot commented on August 13, 2024

GV("XLVDT Sens") ☹️

Did you try GV("XLVDTSens") ie no e at the end as well? That is what is listed in the master variables table :
image

from asylum-api.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.