Giter Club home page Giter Club logo

Comments (2)

vweevers avatar vweevers commented on June 6, 2024

We can't do it exactly the way I proposed in Level/memdown#186 (comment):

In level-js, store strings as (array)buffers

Because not all runtime environments support binary keys. In those we must use string keys only.

I'm thinking we'll replace:

level-js/index.js

Lines 143 to 151 in 86dd5e7

Level.prototype._serializeKey = function (key) {
if (Buffer.isBuffer(key)) {
return Level.binaryKeys ? key : key.toString()
} else if (Array.isArray(key)) {
return Level.arrayKeys ? key.map(this._serializeKey, this) : String(key)
} else {
return key
}
}

With:

Level.prototype._serializeKey = function (key) {
  if (Level.binaryKeys) {
    return Buffer.isBuffer(key) ? key : Buffer.from(String(key))
  } else {
    return String(key)
  }
}

from level-js.

vweevers avatar vweevers commented on June 6, 2024

Also try to find a way to support reading/migrating existing data (that was stored as a string).

from level-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.