Giter Club home page Giter Club logo

Comments (5)

lesterchan avatar lesterchan commented on June 13, 2024

You can overwrite the path

add_filter( 'wp_polls_cookiepath', 'wp_polls_cookiepath' );
function wp_polls_cookiepath() {
return COOKIEPATH;
}

from wp-polls.

foliovision avatar foliovision commented on June 13, 2024

Hello Lester,

I see that, but won't it be better if your plugin worked properly from the start and no tweaks would be needed?

Thanks,
Martin

from wp-polls.

lesterchan avatar lesterchan commented on June 13, 2024

I am not too sure of the impact of SITECOOKIEPATH vs COOKIEPATH, since all the while I have been using SITECOOKIEPATH and so far you are the only person reported this. So I rather be cautious and not change anything that drastic before knowing more. I just provide you the solution to get what you need.

from wp-polls.

lesterchan avatar lesterchan commented on June 13, 2024
= Version 2.65 =
* NEW: Use Dashicons
* NEW: Supports TinyMCE 4.0 For WordPress 3.9
* NEW: Added Poll ID after adding it
* FIXED: Use SITECOOKIEPATH instead of COOKIEPATH.
* FIXED: Use http://ipinfo.io instead of http://ws.arin.net to get check IP information.
* FIXED: Wrapped all JS function in jQuery.ready(). It is ugly, but it will do till I have time to rewrite it.
* FIXED: Add INDEX for wp_pollsip: pollip_ip_qid (pollip_ip, pollip_qid) to prevent full table scan. Thanks archon810 from AndroidPolice.

I can't remember why I change it because it is ages ago, but before that it was on COOKIEPATH

from wp-polls.

foliovision avatar foliovision commented on June 13, 2024

Hello Lester,

my guess is that somebody had COOKIEPATH broken on their site but SITECOOKIEPATH set properly.

wp_set_comment_cookies() seems to work with COOKIEPATH: https://github.com/WordPress/WordPress/blob/master/wp-includes/comment.php#L515-L517

So I'm thinking perhaps the issue was with admin-ajax.php.

WordPress login seems to be setting the cookie for both, you could be doing something similar in your plugin: https://github.com/WordPress/WordPress/blob/master/wp-login.php#L415-L417

Thanks,
Martin

from wp-polls.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.