Giter Club home page Giter Club logo

Comments (5)

jwilsson avatar jwilsson commented on September 25, 2024

I totally agree and have actually been thinking about this myself.

Another feature that could follow from this is the ability to specify the severity of a rule violation. Everything defaults to warning but if desired, mark some rule violations as errors and exit with a different code etc.

@kokarn thoughts, ideas?

from lesshint.

shellscape avatar shellscape commented on September 25, 2024

👍 to the ability to override severity

from lesshint.

kokarn avatar kokarn commented on September 25, 2024

I think @jwilsson is spot on with this and that we all agree that's something that could be useful.

I don't think we should follow jshint tho, add warnings/info to an error object seems a bit backwards and the one letter codes just seems a bit stupid.
@shellscape Do you know why they do single letters?

I think that we should either return a single object with all warnings/error/info on it or a single object with three objects, each containing it's own type.

The more i think about it i like the second alternative a bit more, would be easier to enumerate, could enable handling of specific types differently without having to loop over everything and so on.

from lesshint.

shellscape avatar shellscape commented on September 25, 2024

@kokarn no clue why they used single letters - if I had to guess it was left over from jslint or just a style choice. I'm personally OK with an array of result objects, each with their 'state' property. Splitting that up into { warnings: [], errors: [] } is a matter of stylistic preference at that point, or another way to map the data.

I've started work on this on our fork and will submit PRs along the way.

from lesshint.

jwilsson avatar jwilsson commented on September 25, 2024

Closing this, since everything's fine and dandy in #47.

from lesshint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.