Giter Club home page Giter Club logo

Comments (9)

kokarn avatar kokarn commented on September 25, 2024

I'd suggest changing the default value to include_zero. Removing extra zeroes is something a minifier should do, not the hinter imo. Also it should probably be the same as leadingZero for consistency

from lesshint.

CITguy avatar CITguy commented on September 25, 2024

Could we combine trailingZero and leadingZero into a padZero (or other appropriate name)?

This linter would accept the following options:

  • leading (default)
  • trailing
  • none
  • both

Examples

font-size: .5em;   // none
font-size: 0.5em;  // leading
font-size: .50em;  // trailing
font-size: 0.50em; // both

from lesshint.

kokarn avatar kokarn commented on September 25, 2024

👍 Makes it more consistent with the other linters as well

from lesshint.

jwilsson avatar jwilsson commented on September 25, 2024

@CITguy Nice idea. You wanna take a stab at implementing it?

from lesshint.

CITguy avatar CITguy commented on September 25, 2024

I can see what I can do. Does padZero work as a linter name, or does anybody have a better suggestion?

from lesshint.

kokarn avatar kokarn commented on September 25, 2024

I feel like it's not great but I can't come up with a better one. It's not really a zero padding, it's more like a zero enforcing linter. Maybe forceZero, valueZero, decimalZero or something like that?

from lesshint.

CITguy avatar CITguy commented on September 25, 2024

decimalZero works. I'll get working on this, today.

from lesshint.

CITguy avatar CITguy commented on September 25, 2024

Good news. I've got the functionality working. I just need to clean things up before submitting a PR. Should have it submitted sometime this evening.

from lesshint.

kokarn avatar kokarn commented on September 25, 2024

Great! I'll close this for now so we can continue discussion in #69

from lesshint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.