Giter Club home page Giter Club logo

Comments (5)

madivad avatar madivad commented on August 23, 2024 1

I did download it through the Arduino IDE, I just edited the library file directly, so hopefully when the new version is pushed my manual edit will be replaced by yours, I'll check it myself later. Thanks for your quick and speedy response to this, it did have me pulling my hair out since my google fu was not finding the fork initially. I never even thought to check for that. Thanks again

from button2.

LennartHennigs avatar LennartHennigs commented on August 23, 2024

Hey,
you are correct in both instances – yes, there is no function like this in my class and yes, I did see a fork where lewisxhe implemented it.

Well, I never thought it was really needed, since you assign the pin in the constructor or in the begin() function and you most likely have the pin defined it as a constant or via a #define on the top of you sketch.

But I am could be convinced otherwise :-) Any thoughts on why it makes sense to have it?

Cheers
l.

from button2.

madivad avatar madivad commented on August 23, 2024

I only just found the fork in the last few minutes, I'm working through some example code and I haven't got into the hows and whys yet.

I think in the cases I have seen it's been the fact that various buttons are mapped and they would want to be determining which button has activated the callback.

I was trying to rework the original code because I could see that's what they were trying to achieve, but this level of .cpp and callbacks and references is a little beyond my level of understanding.

from button2.

LennartHennigs avatar LennartHennigs commented on August 23, 2024

Well, its a quick fix. I'll add it to the main branch and release it today.
Will close this when I push it.
Do you download the source from here or shall I make it a proper version and push it Arduino IDE/Platform.io as well?

from button2.

LennartHennigs avatar LennartHennigs commented on August 23, 2024

created a new version and it wil be available through the Arduino IDE or here via download.

from button2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.