Comments (2)
There's also an advantage of having the extra space, it makes the log file grammar a bit less ambiguous to parse, because the 's is never part of an interesting token and serves as a separator.
eg
Earthbind Totem 's Earthbind was evaded by Anvilrage Footman.
when you see the " 's " you know the npc/player name has ended.
while with
Earthbind Totem's Earthbind was evaded by Anvilrage Footman.
it's not obvious what Earthbind Totem's Earthbind is, because ' is allowed inside npc names. Harder to tell when the npc name ends and spell name starts. You need context or lookahead/lookbehind lookups or multiple passes over the line to parse it all and then to remove the optional trailing 's from names.
The legacyplayers code currently considers 's as part of a name to be an error.
https://github.com/YamaYAML/LegacyPlayersV4/blob/8cd83675602a1ba6df34e58a034f4539f1d7bd6e/Backend/src/modules/live_data_processor/tools/cbl_parser/wow_vanilla/parse_unit.rs#L20-L21
parsing would have to change a bit https://github.com/YamaYAML/LegacyPlayersV4/blob/8cd83675602a1ba6df34e58a034f4539f1d7bd6e/Backend/src/modules/live_data_processor/tools/cbl_parser/wow_vanilla/parser.rs#L97-L142
And then there's the question of backwards compatibility versus invalidating all old logs + telling everyone to update the combat log addon they have.
from legacyplayersv4.
Interesting find! As each upload is parsed during upload the damage is done but we should definately look into the logger for future use and less breaking of other add-ons. Tbc
from legacyplayersv4.
Related Issues (20)
- The prophet Skeram in AQ40 only showing the last phase on logs
- C'Thun from AQ40 only displaying Phase 2 on logs
- Nefarian from BWL only showing phase 2 on logs
- Mages fireball periodic damage counted as fireball casts on logs.
- Curse of Elements/Reck/Shadow not showing on logs
- Duplicated boss - Fankriss the Unyielding / Picking Temple of Ahn'Qiraj as encounter does not work.
- Register button absent, addon zip. download broken, unusable for new users
- Could you please upload the battle diary of the Asian server (Chinese) client?
- Some players have class 'NPC/N.A' and armory info unavailable
- search and select all options disappear from abilities selection frame when you change segment.
- Get rid of the junk log events generation "at the charge of the user"
- The logging addon erases SPELLFAILCASTSELF and SPELLFAILPERFORMSELF strings, breaking the functionality of many other addons [vanilla]
- E-mail not functioning HOT 1
- Hunter pets with same name as players make the players and pets not show up on logs. HOT 1
- Druids don't show up in PvE ranking
- Sunder armor and Faerie Fire dont show up
- Magmadar doesn't show up in MC logs
- Mind Controlled mobs don't count towards player damage
- Gothik the Harvester on logs doesn't count phase 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from legacyplayersv4.