Giter Club home page Giter Club logo

Comments (3)

stevemao avatar stevemao commented on June 18, 2024

You should maybe specify that left-pad does not handle code points out of BMP plan as single characters.

Let's add it to the docs. PR welcome

from left-pad.

dubzzz avatar dubzzz commented on June 18, 2024

I had a look to the implementation selected by latest versions of ECMA for padStart. They chose to consider code points outside the BMP plan as two distinct characters.

With padStart on Chrome and Firefox I get the following:

'a\u{1f431}b'.padStart(4, 'x') => "a🐱b"
'abc'.padStart(4, '\u{1f431}') => "\ud83dabc"

from left-pad.

dubzzz avatar dubzzz commented on June 18, 2024

If the choice of left-pad is to be compliant with padStart then the only way to handle this case would be to solve the issue of the third argument not accepting multiple characters.

Otherwise if the choice is leftPad on code points (and not code units) the fix consists in measuring the size of the input string by by-passing String.length and measuring the length manually (only characters in the range \ud800 to \udfff can be by pairs). Then the pad code will be the same.

from left-pad.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.