Allow spaces in default values about ngx_http_geoip2_module HOT 3 CLOSED

Yeah, I thought about that when it was implemented, but it hasn't come up
as a problem until now. I'll see if I can get some time to look at it.

On Thursday, 21 July 2016, Luis Hdez [email protected] wrote:

Not 100% sure but apparently there is no way to use spaces in default
values.

If I use default=Foo\ Bar it shows the Foo\ Bar
If I use default="Foo Bar" it shows the "Foo and cuts the value and
breaks the request

Thanks

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#31, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAehYUbCIl4Zk_2wCEvpNiYfUcHL28_Tks5qX9x5gaJpZM4JSNNY
.

Sent from Gmail Mobile

from ngx_http_geoip2_module.

Sorry for taking so long on this issue. I have found out that nginx allowed this behaviour by default and no change is required to the module.

You can use "default=Foo Bar"

Testing with the following:

    log_format testing '"$geoip2_country_name" $geoip2_country_name';

    geoip2 GeoLite2-Country.mmdb {
        $geoip2_country_name "default=Foo Bar";
    }

    server {
        access_log access.log testing;
        listen 80;
        location / {
            return 200;
        }
    }

Produces the following in the access log:

"Foo Bar" Foo Bar

from ngx_http_geoip2_module.

Great! Thanks for letting me now

from ngx_http_geoip2_module.