Comments (4)
leeoniya
commented on May 19, 2024
1
yeah, so this was a bug in the selector tokenizer. it was splicing the pseudos into the wrong position. that m you posted above definitely looked wrong. the specific fix was line 39. that commit also includes a tweak to the attr regex to ignore surrounding single quotes around values (for normalization); before, only double quotes were ignored.
thanks!
from dropcss.
leeoniya
commented on May 19, 2024
yeah that's the general idea. it would be useful to add some context to the error like pos, previous token (or prev x chars) and next x chars.
you can try temporarily undoing the <br/> fix with these guards in place and see if it makes the problem diagnosis trivial, too.
from dropcss.
heygrady
commented on May 19, 2024
BTW, the repl.it link is the same but the html/css it's testing has changed. I think that wasn't clear.
Anyway, not sure why but the issue is that find is looping forever.
https://github.com/leeoniya/dropcss/blob/master/src/find.js#L186-L187
// if you count down the idx by default it will finish
default:
ctx.idx--;m looks like this:
["body","_"," ","input","_",["'color'","=","type","["],["'date'","=","type","["],"not",":",["'week'","=","type","["],"not",":",["'range'","=","type","["],"not",":",["'radio'","=","type","["],"not",":",["'month'","=","type","["],"not",":",["'checkbox'","=","type","["],"not",":","not",":"]from dropcss.
leeoniya
commented on May 19, 2024
reduced initial testcase for this to:
<body><input></body>body input:not([type='color']):not([type='checkbox']) {}:not at least 2 times on a descendant element appears to be the necessary pre-condition to trigger this.
from dropcss.
Related Issues (20)
- unquoted last attr breaks html parser HOT 5
- attributes with : HOT 5
- Gulp task HOT 1
- support custom property fallback values
- PostCSS plugin HOT 5
- Nextjs integration example HOT 4
- didRetain() instead of result.sels HOT 2
- Using DropCSS with a Ghost blog HOT 1
- didRetain missing in npm published version HOT 3
- Enable hooks to drop / retain individual css declarations HOT 1
- As a postcss plugin ? HOT 1
- Whitespace inside a closing html tag breaks the parser HOT 6
- `NASTIES` regex incorrectly matches custom elements HOT 2
- Trying to get in touch regarding a security issue HOT 1
- new selectors and nesting HOT 1
- css selector parser cannot advance past unsupported pseudo classes with parenthesis HOT 7
- Class names containing html/body/head do not get dropped HOT 2
- Version Drift HOT 1
- Cannot read property '1' of null HOT 1
- Infinite loop on ":where" selector HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dropcss.