Box model defined globally with wildcard about reflex HOT 8 CLOSED

This is my personal preference. I always want to use box-sizing: border-box myself. Is it causing you problems?

from reflex.

I'm also a big fan of setting box-sizing to border-box as I consider it a best practice, but I'm working on a project with a large codebase that unfortunately has a lot of components relying on the fact that the default value is content-box.
Would you ever consider to make the rule specific to the grid and its children?

from reflex.

This is a fair point actually. I will consider changing this in the next version. In the meantime you could change this yourself fairly easily right? I guess it depends on how you are loading the scss/less/css.

from reflex.

Yes, in the meanwhile I can definitely do that. Thank you!

from reflex.

If it's a best practice to have box-sizing: border-box then it would be better to keep it like that and customize it when needed.

from reflex.

I don't see the harm in moving the box-sizing wildcard selector inside the grid as it ensures the grid's css is all self-contained without affecting anything outside the grid itself.

However, as most sites will already be using box-sizing: border-box; it does worry me that we'd have redundant properties inside this library but I feel like this is the best solution for the reason outlined above.

from reflex.

This is changed in commit 5a43751 to master and I will release a new version soon

from reflex.

Thanks @leejordan!

from reflex.