Landscape mode about react-native-swiper HOT 13 CLOSED

The problem is that Swiper gets windows dimensions one time on execute rather than on render, but I've worked around this by getting window dimensions in my render function and passing those values to the width and height props of <Swiper>.

render () {
  const { width, height } = Dimensions.get('window')
  return (
    <Swiper width={width} height={height}>
       ...
    </Swiper>
  )
}

When the window dimensions change, Swiper's componentWillReceiveProps method is called, which updates the dimensions in its state.

from react-native-swiper.

@timmywil Yup

Though ultimately I don't think Swiper even has a reason to try using the window dimensions to fill the page. It makes much more sense to use flex and onLayout.

from react-native-swiper.

+1 afaik it does not support landscape?

from react-native-swiper.

Looks related to #16

from react-native-swiper.

Any suggestions for making react-native-swiper work in landscape mode?

Thanks for a great component!

from react-native-swiper.

Any news on this ?

from react-native-swiper.

+1

from react-native-swiper.

+1 too. It works on first load, but dimensions do not update upon rotating device. Even when manually updating Swiper width after device rotation, it doesn't actually update.

from react-native-swiper.

+1

from react-native-swiper.

+1 too. I've tried so many ways to force the update after device rotation, like invert width and height, but it's not a good practice at all.

Someone did find a decent solution ?

from react-native-swiper.

Seems this broke again when I updated react-native to 0.46.2. componentWillReceiveProps isn't called anymore. This project doesn't seem to be getting support anymore, so I may fork it or just build a custom one for my needs.

from react-native-swiper.

@timmywil Does this properly change orientation to landscape now? I've been unable to get that working so far.

from react-native-swiper.

Is it working now ?

from react-native-swiper.