Comments (3)
I also noticed that the Music Importer class' #import method needs to be an instance method, not a class method as .import would suggest in the README
from ruby-music-library-cli.
I agree that this is an issue! We emphasize single source of truth to our students, so it's very confusing for them that these tests force them to create multiple sources of truth.
from ruby-music-library-cli.
Hi there! Thank you for spotting this issue and providing feedback. The materials have been updated to implement a single source of truth.
Thanks for contributing to the Flatiron School curriculum
from ruby-music-library-cli.
Related Issues (20)
- Modules and CLI Spec
- Tests for .all and .destroy_all need to be improved
- Weak tests HOT 1
- Code expected is not DRY-ing HOT 1
- CLI Commands HOT 1
- Does not recognize not re-coding song#create method in find_or_create_by_name HOT 3
- Instrc HOT 1
- What happened? HOT 1
- Namespacing Syntax on Concerns::Findable HOT 2
- Song.find_by_name method spec seems broken HOT 1
- Cannot open files in the folders in IRB HOT 1
- Terminal keeps restarting HOT 1
- The folders in the Music CLI lab cannot be opened - so I cannot do this lab at all. Thanks HOT 1
- Suggestions for improvement - Music Library CLI Lab HOT 1
- wont load lab HOT 1
- Module Findable in ruby music library is not getting Loaded HOT 1
- I think the spec breaks on test 80 HOT 1
- Discrepancy between readme & test HOT 1
- All three videos at the bottom of the README are unavailable HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ruby-music-library-cli.