Giter Club home page Giter Club logo

Comments (6)

sgouezel avatar sgouezel commented on September 23, 2024

Looks very good. I wondered if one should rather use the Isabelle order for parameters, i.e.,write
eventually (\lamba n, u n ≥0) at_top
or
eventually at_top (\lamba n, u n ≥0)
But in the end both are understandable even if one does not know that a filter is involved in the statement. And the second order, that you have chosen, makes it possible to also write at_top.eventually. So it is fine with me!

from mathlib.

johoelzl avatar johoelzl commented on September 23, 2024

The f.eventually notation is more flexible, both orders would work. I didn't use the Isabelle order, as it felt more natural to write the object we are operating on in the first position. Do you have a case were Isabelle's order has an advantage? In Isabelle most quantifiers over datatypes follow the form t_all : ('a -> bool) -> ('a t -> bool). I don't know if we have any precedence yet in mathlib.

Anyway, I hope that users don't directly write down eventually or frequently but use the quantifiers.

from mathlib.

johoelzl avatar johoelzl commented on September 23, 2024

If the user wants to use eventually, with Isabelle's order they have the advantage to choose between: f.eventually p or eventually p f. Unfortunately f.eventually itself does not work, it's missing the p.

I guess I will change it to Isabelle's order

from mathlib.

sgouezel avatar sgouezel commented on September 23, 2024

To me, the argument in favor of Isabelle order is that it looks more like a regular English sentence. But this is a weak argument.

from mathlib.

urkud avatar urkud commented on September 23, 2024

Added notation in #1845. Should we close this issue, or leave it to discuss what parts of the library should / should not be migrated to this notation?

from mathlib.

jcommelin avatar jcommelin commented on September 23, 2024

I think it's fine to close this now.

from mathlib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.