Alert views presented on wrong view controller about leanplum-ios-sdk HOT 7 CLOSED

We'll fix this in the next release. In the meantime, there is a workaround. First, add LPMessageTemplates.h/m to your project. These files are available if you download the SDK from Help > Setup. You'll need to initialize these templates by calling [LPMessageTemplates sharedTemplates] before calling [Leanplum start]. Then, in LPMessageTemplates.m, add this method:

+ (UIViewController *)visibleViewController
{
    UIViewController *root = [UIApplication sharedApplication].keyWindow.rootViewController;
    if (root.presentedViewController) {
        return root.presentedViewController;
    }
    return root;
}

And replace both occurrences of:

[[UIApplication sharedApplication].keyWindow.rootViewController presentViewController:alert animated:YES completion:nil];

with:

[[LPMessageTemplatesClass visibleViewController] presentViewController:alert animated:YES completion:nil];

from leanplum-ios-sdk.

Do you know when the next release will happen? We're trying to determine if we should put in this fix now or if we should wait. Also, when you say next release are you referring to a new SDK?

from leanplum-ios-sdk.

I would say within a week. The fix was tested in different scenarios, but if you have time to test it in your app, that would make sure we covered your specific use case.

from leanplum-ios-sdk.

Thanks for the update. We'll run tests in our app with the fix you recommended and will let you know how it turns out.

from leanplum-ios-sdk.

Hi @afirst,

I tried your workaround, and it almost works. However, sometimes we have multiple view controllers presented on the rootViewController, so the following works better for us for the visibleViewController method:

+ (UIViewController *)visibleViewController
{
    UIViewController *topController = [UIApplication sharedApplication].keyWindow.rootViewController;
    while (topController.presentedViewController) {
        topController = topController.presentedViewController;
    }
    return topController;
}

We are still testing to see if this works in all situations, but so far things are much improved.

from leanplum-ios-sdk.

Glad you were able to test it and thanks for the feedback! We'll incorporate that change.

from leanplum-ios-sdk.

Cleaning up the opened issues.
I just made a sample app and did not show any error.

from leanplum-ios-sdk.