Comments (6)
Its touched on here: https://who.ldelossa.is/posts/gh-nvim/#cli-dependencies
The background refresh keeps gh.nvim in sync with the GitHub api. But it wont do much if a pr is not open, or issue buffers arent open. Its required to get new comments / new PR commits / etc... automatically.
from gh.nvim.
Ok, thanks! Still, I think the echo on neovim startup is unnecessary. Would you mind to make it optional?
from gh.nvim.
Sounds find to me. Want to send a PR for this? Ill approve.
from gh.nvim.
I'm looking into it. I'm wondering: do we really need to start the refresh timer within init.lua
:
Line 265 in caed363
I mean, it is understandable that we want this timer when we open a PR or issue, but do we want it already when a user does the setup()
function?
My intuition would be that we could just remove that line. It would resolve my issue. But perhaps I'm missing something?
from gh.nvim.
The timer is used to refresh arbitrary Issue buffers which can be open at any time, and unrelated to having an open PR.
Its a lot simpler to just launch the timer which runs a no-op function if no Issues or PR is open, rather then trying to ref count open Issue buffers or open PRs. The no-op timer is not going to effect UX or performance when no Issue or PR buffers are open.
from gh.nvim.
Closing this as we can continue the discussion in #42.
from gh.nvim.
Related Issues (20)
- not defaulting to telescope with lazy.nvim HOT 3
- UI/Rendering Questions HOT 1
- left side of diff always blank HOT 1
- Is this unavailable with vimScript and plug-vim? HOT 1
- [+] icon of column sign is not showing, randomly.
- [Question] what is the 'select' option for?
- Failed to list PRs HOT 1
- Pull requests with force pushes can't be opened
- windows support
- when submitting a review (comment/request changes) comment can only be one line HOT 1
- Have the ability to start a thread on the file not just the lines HOT 3
- Close all tmp buffers when closing prs HOT 1
- Error when opening a PR HOT 2
- Manage file viewed state in PR HOT 3
- Failed to determine if remote branch exists - auth problem
- When toggling a thread the diff view lost colors
- Original side of diff is empty HOT 1
- Hostname is not respected in all calls.
- Submitting thread comment <C-s> fails.
- [FR] Show comments in virtualtext or hover/floating window
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gh.nvim.