Giter Club home page Giter Club logo

Comments (6)

ldelossa avatar ldelossa commented on June 27, 2024 1

Its touched on here: https://who.ldelossa.is/posts/gh-nvim/#cli-dependencies

The background refresh keeps gh.nvim in sync with the GitHub api. But it wont do much if a pr is not open, or issue buffers arent open. Its required to get new comments / new PR commits / etc... automatically.

from gh.nvim.

lervag avatar lervag commented on June 27, 2024

Ok, thanks! Still, I think the echo on neovim startup is unnecessary. Would you mind to make it optional?

from gh.nvim.

ldelossa avatar ldelossa commented on June 27, 2024

Sounds find to me. Want to send a PR for this? Ill approve.

from gh.nvim.

lervag avatar lervag commented on June 27, 2024

I'm looking into it. I'm wondering: do we really need to start the refresh timer within init.lua:

M.start_refresh_timer()

I mean, it is understandable that we want this timer when we open a PR or issue, but do we want it already when a user does the setup() function?

My intuition would be that we could just remove that line. It would resolve my issue. But perhaps I'm missing something?

from gh.nvim.

ldelossa avatar ldelossa commented on June 27, 2024

The timer is used to refresh arbitrary Issue buffers which can be open at any time, and unrelated to having an open PR.

Its a lot simpler to just launch the timer which runs a no-op function if no Issues or PR is open, rather then trying to ref count open Issue buffers or open PRs. The no-op timer is not going to effect UX or performance when no Issue or PR buffers are open.

from gh.nvim.

lervag avatar lervag commented on June 27, 2024

Closing this as we can continue the discussion in #42.

from gh.nvim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.