Comments (5)
They are both as secure as it needs to be for the application.
Changing it would be a pointless hardfork and engineering effort.
from torba.
To add some clarification to this: I think @ocornoc was specifically referring to how the wallet is encrypted on disk and not necessarily what SHA was used for the blockchain itself.
My answer is the same as Kay's though: Bitcoin and LBRY use SHA256 to secure the blockchain. If there is a valid argument that SHA256 is not secure then it seems that fixing the blockchain would be significantly higher priority than how you encrypt your wallet.
Also, torba intends to be at least somewhat backwards compatible with electrum; there are many existing wallets with encrypted seeds/keys via the old electrum wallet which now need to be decrypted with torba. Changing how encryption works would require tracking which version of the algorithm was used to encrypt the wallet and then decrypting it with the correct decrypt algorithm. For a long time, both the 256 and 512 versions would be included in the code to be able to open old wallets; this would add unnecessary technical debt.
If SHA256 is not secure then we have much bigger problems on our hands.
from torba.
@eukreign Can you please triage?
from torba.
I would suggest @jackrobison and @kaykurokawa check this one out
from torba.
@eukreign is correct in the interpretation: I was specifically referring to torba's on-disk encryption.
And, eukreign, you are right (if I'm picking up on what you were saying correctly): SHA-256 is secure, and there may be reasons to keep SHA-256 in use whether or not it is optimally secure, such as backwards compatibility.
As an explanation of my original post, I had meant that SHA-256 is a secure hashing algorithm, though it may not be the most secure hashing algorithm readily available. I was attempting to provide reasons as to how truncated SHA-512 may be more secure than SHA-256, irregardless as to whether either of them were secure themselves.
from torba.
Related Issues (14)
- Support Blockchain Reorganization HOT 3
- Calculate total proof of work HOT 4
- switch to cryptogrophy for generating addresses
- Improve timeout for network calls made during a reconnect or internet outage
- db indexes for any queries involved with wallet sync HOT 3
- manually manage db transactions HOT 1
- make it easier for other teams to write integration tests with torba
- xpub and xprv don't match lbrycrd HOT 2
- command to start spv server
- Comply with repository standards
- Consistent code style HOT 1
- Refactor orchstr8 to work with supported API calls
- Support sending to multisig (script) addresses
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from torba.