Giter Club home page Giter Club logo

Comments (4)

lbdremy avatar lbdremy commented on July 19, 2024

Hello @scherler,

Why do you want to change the version number? I don't understand

I try to follow semver conventions http://semver.org/.
Well at the moment that's quite easy, when the major version is with 0, it means that the API is not stable and that anything can change but I won't do that.
If something is removed in the API, I will bump the minor version number. If we add some new stuff do the API without breaking backward compatibility I will bump the patch version number. My plan is to support Solr 4 interface in solr-client 0.3.x, when this new version will be tested in production and review my other contributors I will bump the version to 1.0.0, which will be the first stable regarding semver. At this stage I will respect semver conventions without exceptions. :)

from solr-node-client.

scherler avatar scherler commented on July 19, 2024

The current number is the same as the published one in npm.

I am Apache member and in all projects I had the pleasure to participate the released version is not the same of the current HEAD of development. ...but that is not true, since e.g. ATM the facet feature is not in the published lib but in HEAD but both have the same version number which is not logical. Head should be the "unreleased" next version of the product.

Point is: current HEAD version > current release version

from solr-node-client.

lbdremy avatar lbdremy commented on July 19, 2024

Ì see what you mean, but it is common pattern in the node.js community to update the version in the package.json when doing a release and publishing on npm, between two version we don't change the version number, only on the next release. Each version that appear in the package.json are published on npm. If you like to use feature a in master not yet released and so unavailable on npm, you can directly point to the git repo when you declare your dependencies in the package.json. It would be something like this:

{
 "dependencies" : {
 "module-name" : "git://github.com/user/project.git#commit-ish"
}
}

You can learn more stuff about it in the dependencies section on this page https://npmjs.org/doc/files/package.json.html.

Anyway that may be a good practice to make thing clearer, thanks for the suggestion, I will probably apply it after the next release.

from solr-node-client.

lbdremy avatar lbdremy commented on July 19, 2024

I think I may close this, thanks for the comment @scherler.

from solr-node-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.