Giter Club home page Giter Club logo

Comments (7)

lbdremy avatar lbdremy commented on July 19, 2024

This is implemented, need a test to close this issue.

from solr-node-client.

juzerali avatar juzerali commented on July 19, 2024

Not working at my end. See the url that is getting formed:
GET /solr//update/json?commit=false&stream.contentType=text%2Fplain%3Bcharset%3Dutf%5C-8&stream.file=%2Fhome%2Fjuzer%2FDesktop%2FOpen%5C-Source%2Fsolr%5C-node%5C-client%2Fexamples%2Fbooks.json&wt=json HTTP/1.1\r\nHost: 127.0.0.1:8983\r\nConnection: keep-alive\r\n\r\n

Notice double slashes at solr//update

from solr-node-client.

juzerali avatar juzerali commented on July 19, 2024

After merging #42, url is correctly generated, but a problem is occuring in defining charset in contentType. See the formed url:
update/json?commit=false&stream.contentType=text%2Fplain%3Bcharset%3Dutf%5C-8&stream.file=.%2Fexampledocs%2Fbooks.json&wt=json

note charset%3Dutf%5C-8 should just be charset%3Dutf-8

from solr-node-client.

juzerali avatar juzerali commented on July 19, 2024

Strange bug, don't know if something is wrong with solr or node itself. On
Ubuntu 12.10
node V0.8.5
solr-client github build

Steps to reproduce

1 $ cd solr-node-client && node
2 > qs = require('querystring')
3 > qs.stringify({key: '-'}) //-> key=-
4 > client = require('./lib/solr').createClient()
3 > qs.stringify({key: '-'}) //-> key=%5C-

What just happened?

from solr-node-client.

lbdremy avatar lbdremy commented on July 19, 2024

Thanks I know exactly what's going on, that's because I overrided qs.escape used by qs.stringify and I escape specials characters of Solr and also encode uri components (https://github.com/lbdremy/solr-node-client/blob/v0.3.x/lib/query.js#L13). I will undo these changes. Thanks for noticing this :). These changes are in the branch v0.3.x now.

from solr-node-client.

marc-portier avatar marc-portier commented on July 19, 2024

To summarize: To close this we just need an extra test for this? Correct?

from solr-node-client.

lbdremy avatar lbdremy commented on July 19, 2024

yes we need a test for it .

from solr-node-client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.