WorldType enum change causes build fail about runelite-bank-memory-plugin HOT 4 CLOSED

Hi there, I'm currently away on holiday so I won't be working on it for a little while. I hope to get on to it when I get back, some time a week (+) from now

from runelite-bank-memory-plugin.

Update: Was able to work around this by checking whether if the world type is both seasonal and deadman:

public static BankWorldType forWorld(EnumSet<WorldType> worldTypes) {
    if (worldTypes.contains(WorldType.SEASONAL)) {
        return worldTypes.contains(WorldType.DEADMAN) ? BankWorldType.DEADMAN_TOURNAMENT : BankWorldType.LEAGUE;
    }
    if (worldTypes.contains(WorldType.TOURNAMENT_WORLD)) {
        return BankWorldType.TOURNAMENT;
    }
    if (worldTypes.contains(WorldType.DEADMAN)) {
        return BankWorldType.DEADMAN;
    }
    return BankWorldType.DEFAULT;
}

Huzzah!

from runelite-bank-memory-plugin.

Thank you @Septem151 for resolving this with the following commits:

c25b7c8
1b55c45
129f6fc

from runelite-bank-memory-plugin.

Hi there, I'm currently away on holiday so I won't be working on it for a little while. I hope to get on to it when I get back, some time a week (+) from now

When you get the chance, I've submitted a PR #6 to fix this.

However, there's a slight problem (that can be addressed later on). You're using different world types for DMM, DMM tournament, and leagues, but the new net.runelite.WorldType enum only contains enums for TOURNAMENT_WORLD (which includes DMM tournaments), DEADMAN (which includes DMM), and SEASONAL (which contains both Leagues and Seasonal DMM).

Therefore the "DEADMAN_TOURNAMENT" and "DEADMAN" BankWorldTypes will become the same, with one of them not being used anymore. Can't simply delete the BankWorldType enum for it because of this comment:

// NB: changing these name will break automatic JSON deserialisation of existing saves

So for now, the PR just fixes the issue of building for the plugin hub, but the aforementioned is an issue that needs to be looked at further.

from runelite-bank-memory-plugin.