Space added for raw SQL? about hugsql HOT 6 CLOSED

This may be bug. I know there were a few edge cases with whether or not to add a space for clojure expressions if the returned string did not account for any space. Raw SQL parameters may need to have different behavior for the intuitive use. I'll look into this.

The work-around for your particular issue is to pass in the entire column name "scan_left" or "scan_right". (And, once you're passing in the entire column name, you might as well use the :i identifier param type.)

from hugsql.

Yeah smelled like it 😄 Thanks for the workaround...I used:

UPDATE workflows
/*~ (if (= "left" (:side params)) */
SET scan_left = :scan
/*~*/
SET scan_right = :scan
/*~ ) ~*/
WHERE id = :id
RETURNING *

It works fine...

from hugsql.

That's great, too. Thanks for the bug report!

from hugsql.

This should be in the next release (0.5.0) later this week. Thanks for the report!

This bug prompted me to reconsider some earlier decisions on whether or not to provide a "spacer" when a parameter or expression returns a value that might need one in the context of the SQL. I've now decided to trim less whitespace and newlines when parsing and skip adding a spacer altogether. There are a few edge cases where this change might break someone's existing code, hence the version bump to 0.5.0, but I think in the longer term this is the right thing to do.

from hugsql.

Agree with you and can't wait for the next release! 😃

from hugsql.

This is released in 0.4.8 (finally!). Thanks!

from hugsql.