Variable re-using on VarStore about tch-rs HOT 4 CLOSED

Thanks for the feedback.
The naming behaviour is indeed on purpose. As you noted it would not work if you change the order in which tensors are created, however even when using an index per base name the same issue would arise if you change the order in which tensors with the same name are created. The idea there is that you should name tensor uniquely for most use cases (except very simple snippets hence this behavior).
Reusing the same tensors would also be problematic if queried with different sizes or initialization or even with the same random initialization as it's unclear whether you should reinitialize or not.

Re variable reuse, the idea there is that you should reuse things explicitly - rather than relying on some context magic as would be the case with tensorflow. If you want to use a variable twice, you should just create it once with for example let var = path.zeros(...) and then pass the var tensor to all the places where it is going to be used.
I just added a get function so that you can get tensors back based on a path and a name, but I think the clean way to do things is more to pass tensors as described previously.

from tch-rs.

I agree reusing should be explicitly specified by users. I think passing variables around would lose the convenience of name space hierarchy. Suppose you build two models partially share some params. While you might keep track of bunch of shared variables, VarStore would be a good delegation for this case.

I pushed my entry API nn::Path and you can take a look. It's aimed for those who want to check name existence beforehand. I'm not sure if this change is crucial for most users, and we can merge after we have plenty discussions.

from tch-rs.

Thanks I actually just merged your PR as I think it's a nice addition (as user may indeed end up recoding this kind of thing on their side anyway if they really want to go this way).

from tch-rs.

Closing now as the PR #49 has been merged and released. Feel free to re-open or create new issues/PRs if you have more thoughts on how to improve usability for this.

from tch-rs.