Giter Club home page Giter Club logo

Comments (11)

LaurentiuUngur avatar LaurentiuUngur commented on June 2, 2024

Hello ! I'm glad that you're using it.

Please set estimatedRowHeight and estimatedSectionHeaderHeight to a value that's appropriate to the heights of rows and headers. If I remember correctly, default one is 60 for both, but yours are taller.

from luexpandabletableview.

PaulRBerg avatar PaulRBerg commented on June 2, 2024

Did just that, I set them at 196 before the video was recorded. It s not because of that.

I changed the row animation from fade to none. Maybe because of that?

from luexpandabletableview.

LaurentiuUngur avatar LaurentiuUngur commented on June 2, 2024

You can try changing animation, even playing a little bit with that value to be more precisely with their real height. Also please check constraints, maybe you have some ambiguous constraints. What did you return in delegate methods for height ?

from luexpandabletableview.

PaulRBerg avatar PaulRBerg commented on June 2, 2024

Pasted the methods here

func expandableTableView(_ expandableTableView: LUExpandableTableView, heightForRowAt indexPath: IndexPath) -> CGFloat {
        /// Returning `UITableViewAutomaticDimension` value on iOS 9 will cause reloading all cells due to an iOS 9 bug with automatic dimensions
        return 196
    }
    
    func expandableTableView(_ expandableTableView: LUExpandableTableView, heightForHeaderInSection section: Int) -> CGFloat {
        /// Returning `UITableViewAutomaticDimension` value on iOS 9 will cause reloading all cells due to an iOS 9 bug with automatic dimensions
        return 196
    }

Also, yes there was something strange happening with the constraints. I have a simple container view in the section's header xib and I was always getting the UIViewAlertForUnsatisfiableConstraints alert when the view was collapsing, so I simply changed the constraints from leading, top, bottom, trailing distance of 8 to Less or equal 8. Maybe it's because of this?

More info: The container view is the root view of the header, after the header's own root view of course.

from luexpandabletableview.

LaurentiuUngur avatar LaurentiuUngur commented on June 2, 2024

For top, leading and trailing you can leave it equal to 8. For bottom put it also equal to 8 but change priority to 750. Did the flicker occur even after resolving UIViewAlertForUnsatisfiableConstraints warning ?

from luexpandabletableview.

PaulRBerg avatar PaulRBerg commented on June 2, 2024

Yes, it does unfortunately. With both my edited constraints + your priority 750 suggestion.

from luexpandabletableview.

LaurentiuUngur avatar LaurentiuUngur commented on June 2, 2024

Try setting estimatedRowHeight and estimatedSectionHeaderHeight to 196 and return UITableViewAutomaticDimension in delegate methods. On which iOS version flicker occurs ? On both iOS 9 and 10 ?

from luexpandabletableview.

PaulRBerg avatar PaulRBerg commented on June 2, 2024

It is worse. This is what happens now after I added UITableViewAutomaticDimension and set the height before.

http://sendvid.com/zwqhcmkl

Happens on iOS 10. Didn't test on iOS 9 yet.

from luexpandabletableview.

PaulRBerg avatar PaulRBerg commented on June 2, 2024

Any updates on this?

from luexpandabletableview.

LaurentiuUngur avatar LaurentiuUngur commented on June 2, 2024

Sorry, but I don't have time to investigate until this weekend.

from luexpandabletableview.

LaurentiuUngur avatar LaurentiuUngur commented on June 2, 2024

Sorry for the delay. I took a look at your problem, but I haven't found any solution and I don't have access to your source code.

from luexpandabletableview.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.