Giter Club home page Giter Club logo

Comments (3)

laurent22 avatar laurent22 commented on June 6, 2024 1

Dev info: It happens on packages/lib/services/rest/Api.ts line 247 which means something somewhere is throwing a string instead of an error object

Edit: @personalizedrefrigerator, it's probably this commit: a0f003f When we call reject we should pass an error object instead of a string whenever possible (Actually I saw there's a prefer-promise-reject-errors rule which we should implement to more easily detect those)

from joplin.

personalizedrefrigerator avatar personalizedrefrigerator commented on June 6, 2024

it's probably this commit: a0f003f When we call reject we should pass an error object instead of a string whenever possible

I've created a pull request that should cause the correct error message to be displayed (#10368). While it improves the error message, it doesn't seem to fix the issue.

I'm in the process of doing a git bisect.

Edit:

Error messages when building from #10308

Clipping https://onlinelibrary.wiley.com/doi/10.1111/mmi.15236 from #10368:

There was some error creating the note: {"error":"Internal Server Error: Image at /home/builder/.config/joplindev-desktop/profile-0fof4zei/tmp/mmi15236-fig-0001-m_4abcf3d737f8408dac637304ea39a532.png failed to load.: \n\nError: Image at /home/builder/.config/joplindev-desktop/profile-0fof4zei/tmp/mmi15236-fig-0001-m_4abcf3d737f8408dac637304ea39a532.png failed to load.\n at image.onerror (/home/builder/Documents/joplin/packages/lib/shim-init-node.js:180:50)"}

If I reset handleResizeImage_ to 0e6b5b3 (a commit before it was updated to use an Image rather than native-image), I get

There was some error creating the note: {"error":"Internal Server Error: Image is invalid or does not exist: /home/builder/.config/joplindev-desktop/profile-0fof4zei/tmp/mmi15236-fig-0001-m_cf904fa17b0946f9a12c55e2000a300c.png: \n\nError: Image is invalid or does not exist: /home/builder/.config/joplindev-desktop/profile-0fof4zei/tmp/mmi15236-fig-0001-m_cf904fa17b0946f9a12c55e2000a300c.png\n at /home/builder/Documents/joplin/packages/lib/shim-init-node.js:173:27\n at Generator.next (<anonymous>)\n at /home/builder/Documents/joplin/packages/lib/shim-init-node.js:8:71\n at new Promise (<anonymous>)\n at __awaiter (/home/builder/Documents/joplin/packages/lib/shim-init-node.js:4:12)\n at handleResizeImage_ (/home/builder/Documents/joplin/packages/lib/shim-init-node.js:166:16)\n at Object.<anonymous> (/home/builder/Documents/joplin/packages/lib/shim-init-node.js:278:34)\n at Generator.next (<anonymous>)\n at fulfilled (/home/builder/Documents/joplin/packages/lib/shim-init-node.js:5:58)"}

A git bisect points to 9e0a046 as being the first commit where this issue happens.

from joplin.

jotech avatar jotech commented on June 6, 2024

solved in https://github.com/laurent22/joplin/releases/tag/v3.0.6

from joplin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.