Make profiling alert message soft (and configurable) about explain-pause-mode HOT 10 CLOSED

Maybe even a tristate:

(defcustom explain-pause-alert-style 'normal
  "How often should explain-pause alert you about long pauses in the mini-buffer?"
  :type '(choice (const :tag "Always" developer)
                 (const :tag "Every now and then" normal)
                 (const :tag "Never" silent)))

from explain-pause-mode.

Interesting, didn't know that. I still prefer to be explicit about this.

from explain-pause-mode.

Is there a reason why both can't be disabled by the same customizable?

from explain-pause-mode.

Is there a reason why both can't be disabled by the same customizable?

No reason. At first, I liked the idea that "some messages" are more important than others. But on second thought, you have a point. The profiles and the "alert messages" are basically the same, they are obtrusively interrupting the user.

Now I'm starting to think: really messages shouldn't appear in "normal mode", and occasionally the thing should just say "Hey, emacs was slow N times in the last hour. Check out the report ".

So basically, maybe one main customizable: "developer mode" = like devtools, you get "polite" echo area alerts for both; or "normal mode" = only summary messages every now and again.

from explain-pause-mode.

❤️ 😻 💯

That's so great, thank you for prodding me to remember I'm in emacs and should do things the emacs way. I'll use this entire thing. super appreciate 👍

from explain-pause-mode.

Oh and you probably want to define a group and add all customizables to it for M-x customize-group to work.

from explain-pause-mode.

I think I did the customize-group stuff correctly, but I will be honest I'm literally just following the documentation and grepping what the emacs built-in .el files do, I really am not a elisp developer by any stretch of the imagination... I have this

(defgroup explain-pause nil
  "Explain pauses in Emacs"
  :prefix "explain-pause-")

https://github.com/lastquestion/explain-pause-mode/blob/master/explain-pause-mode.el#L46-L48

which should work, right?

from explain-pause-mode.

Yes, but then you need to use :group explain-pause in every customizable to link them up.

from explain-pause-mode.

So I asked because it seems to work without it :-)

I investigated and discovered this commit emacs-mirror/emacs@805204f in 2016 - which added the text in the docs that I read. The bug report: https://lists.gnu.org/archive/html/bug-gnu-emacs/2016-05/msg00132.html

which seems to be ambivalent on whether it is a good or bad thing that this works.

So I checked elisp dir in emacs itself. of 8210 defcustoms, 6897 have group in their definition with the simple regex search \(defcustom[\s\S]+?:group.

Soooooo OK let's add :group 😀

from explain-pause-mode.

84% of emacs core agrees with you. They probably should just cut the feature, IMHO, but legacy++, that'll never happen now...

from explain-pause-mode.