Giter Club home page Giter Club logo

Comments (7)

laserlemon avatar laserlemon commented on June 29, 2024

Thanks for pointing that out. Could you please submit a pull request?

from figaro.

laserlemon avatar laserlemon commented on June 29, 2024

Do you plan to work on this? If not, I can when I'm free (someday)!

from figaro.

chikamichi avatar chikamichi commented on June 29, 2024

Sorry, I forgot about this one :) Well, I won't have the time to code until early March (vacation, yeah!).

from figaro.

MarkDBlackwell avatar MarkDBlackwell commented on June 29, 2024

I just noticed this issue mentions the same redundant key as issue #35.

from figaro.

MarkDBlackwell avatar MarkDBlackwell commented on June 29, 2024

With pull request #39, at least for Rails apps, the Figaro Rake task you mention (rake figaro:heroku) works, without setting either RAILS_ENV or RACK_ENV as Heroku config keys.

To enable pure Rack apps, the Figaro Rake task code could use RACK_ENV instead. I tried this, and it worked:

$ heroku run "echo \$RACK_ENV"
Running `echo $RACK_ENV` attached to terminal... up, run.6334
production

from figaro.

laserlemon avatar laserlemon commented on June 29, 2024

Figaro isn't intended for pure Rack apps. The new way in which Figaro looks for your remote Rails.env (as of v0.6.2) should properly read RAILS_ENV from Heroku.

from figaro.

chikamichi avatar chikamichi commented on June 29, 2024

@laserlemon Makes sense, this is a nice compromise. Thank you!

from figaro.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.