Giter Club home page Giter Club logo

Comments (3)

semenodm avatar semenodm commented on August 22, 2024

Thank you for using this library, it would be great if you create PR so we can merge this change to mainline. Or i can revisit it little bit later, this problem worth to fix, thank you again for creating the issue this makes this library better.

from fs2-aws.

blissd avatar blissd commented on August 22, 2024

I've experimented with the v3 API and the problem persists. The workaround for v3 is:

fs2.io.readInputStream(
          blocker.blockOn(IO(
            S3Client.create.getObject(
              GetObjectRequest
                .builder()
                .bucket(bucket)
                .key(key)
                .build()
            )
          )),
          chunkSize = 4096,
          closeAfterUse = true,
          blocker = blocker
        )

from fs2-aws.

austinwarrren avatar austinwarrren commented on August 22, 2024

As far as I can tell, it seems this issue has been resolved. Tested today, and discovered through testing that running s3.readFile (method name appears to have changed since creation of this issue) on a path which does not exist in S3 results in the exception NoSuchKeyException being returned, rather than the process hanging as described above. If this is not the case, is there any additional context surrounding the issue which may be useful in resolving it? Or if this issue has been resolved, may this issue be closed? Steps I performed in reaching this conclusion:

  1. Set up S3 environment via localstack.
  2. Create test in S3Suite which should fail in the above specified conditions--added a file key which did not exist.
  3. Test fails, but returns an exception (NoSuchKeyException) rather than an empty stream.

from fs2-aws.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.